Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset #2604

Merged
merged 1 commit into from Jun 16, 2014

Conversation

@Nicofuma
Copy link
Member

commented Jun 15, 2014

https://tracker.phpbb.com/browse/PHPBB3-12722

I think that it's a good idea to have this rule, but also it's nice to be able to format the assignments like in phpBB/includes/acp/acp_jabber.php

PHPBB3-12722

@Nicofuma Nicofuma changed the title [ticket/12717] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset [ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset Jun 15, 2014
@@ -52,11 +52,11 @@ function adjust_item(&$item_row, &$row)
if ($this->is_moderator_approve_forum($row['forum_id']))
{
if ( (int)$row['topic_visibility'] === ITEM_DELETED)
if ( (int) $row['topic_visibility'] === ITEM_DELETED)

This comment has been minimized.

Copy link
@bantu

bantu Jun 16, 2014

Member

Also remove the space at the fron here, please.

This comment has been minimized.

Copy link
@Nicofuma

Nicofuma Jun 16, 2014

Author Member

updated

@@ -0,0 +1,24 @@
{

This comment has been minimized.

Copy link
@bantu

bantu Jun 16, 2014

Member

This file should not be added.

This comment has been minimized.

Copy link
@Nicofuma

Nicofuma Jun 16, 2014

Author Member

updated

bantu added a commit to bantu/phpbb that referenced this pull request Jun 16, 2014
[ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset

* Nicofuma/ticket/12722:
  [ticket/12722] Add Generic.Formatting.SpaceAfterCast in the legacy ruleset
@bantu bantu merged commit ca3cdad into phpbb:develop-ascraeus Jun 16, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.