Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12747] Drop support for Firebird #2629

Merged
merged 2 commits into from Jun 22, 2014

Conversation

Projects
None yet
6 participants
@nickvergessen
Copy link
Contributor

nickvergessen commented Jun 20, 2014

https://tracker.phpbb.com/browse/PHPBB3-12747

What should we do on update? Nothing?

@PayBas

This comment has been minimized.

Copy link
Contributor

PayBas commented Jun 20, 2014

Throw a massive /slap error?

@nickvergessen

This comment has been minimized.

Copy link
Contributor Author

nickvergessen commented Jun 20, 2014

Does "General Error: Missing DB driver" count?

@PayBas

This comment has been minimized.

Copy link
Contributor

PayBas commented Jun 20, 2014

I guess. People using firebird will most likely know their way around their setup. So for them this would probably be good enough. Especially since it will be in the release changelog that support has been dropped.

Unless of course displaying a more descriptive error message is easy to do.

@dhruvgoel92

This comment has been minimized.

Copy link
Contributor

dhruvgoel92 commented Jun 21, 2014

Since we no longer support firebird, "General Error: Missing DB driver" seems good enough to me.

@@ -246,7 +228,6 @@ protected function create_connection_manager($config)
/**
* Converts a match in the middle of a string to uppercase.
* This is necessary for transforming the fixture information for Firebird tests

This comment has been minimized.

@bantu

bantu Jun 22, 2014

Member

I think the whole method can be dropped.

This comment has been minimized.

@nickvergessen

nickvergessen Jun 22, 2014

Author Contributor

Yes, removed it now

bantu added a commit to bantu/phpbb that referenced this pull request Jun 22, 2014

Merge pull request phpbb#2629 from nickvergessen/ticket/12747
[ticket/12747] Drop support for Firebird

* nickvergessen/ticket/12747:
  [ticket/12747] Remove some methods which are not used anymore
  [ticket/12747] Drop support for Firebird

Conflicts:
	phpBB/phpbb/db/driver/firebird.php

@bantu bantu merged commit dc7ed58 into phpbb:develop-ascraeus Jun 22, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@nickvergessen nickvergessen deleted the nickvergessen:ticket/12747 branch Jun 22, 2014

@madorin

This comment has been minimized.

Copy link

madorin commented Dec 12, 2016

Hello!
Just trying to upgrade my board to v3.1 and surprise, no Firebird support. Very sad .. :(
I fixed that PHP PDO bug in 7.x branch some time ago.
Can you reconsider adding Firebird support?
Thanks!

@nickvergessen

This comment has been minimized.

Copy link
Contributor Author

nickvergessen commented Dec 12, 2016

Sorry to hear, but since you are the first one in over 2 years, just shows that it's not worth a lot of work :(

@madorin

This comment has been minimized.

Copy link

madorin commented Dec 12, 2016

It may be just because a lot of users simply does not know how to handle http 500 error code, in case they have specified firebird driver in config on phpbb 3.1 upgrade process.
Firebird probably is most SQL standard compilant dbms from open source world. I saw commit removing FB support, and it does not show a lot of work.

@DavidIQ

This comment has been minimized.

Copy link
Member

DavidIQ commented Dec 12, 2016

As also mentioned in a reply to your forum post:

Currently there are plans/discussions for dropping our whole database abstraction layer and moving to utilizing Doctrine as the DBAL layer (probably in 3.3), which unfortunately doesn't support Firebird neither. Because of this I see basically no chance of adding support for Firebird, unless we find the time to work upstream, however, having very limited capacities it is most likely not gonna happen.
I hope someone proves me wrong though.

Even if we undid these changes, which involved 26 files, FB support would still be dropped once we go with Doctrine since they don't support FB either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.