Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12789] The directories are not deleted when the cache is purged (with memory acm) #2680

Merged
merged 2 commits into from Aug 8, 2014

Conversation

Projects
None yet
4 participants
@Nicofuma
Copy link
Member

Nicofuma commented Jun 30, 2014

@Nicofuma Nicofuma changed the title The directories are not deleted when the cache is purged (with memory acm) [ticket/12789] The directories are not deleted when the cache is purged (with memory acm) Jul 3, 2014

@bantu

This comment has been minimized.

Copy link
Member

bantu commented Jul 6, 2014

A cache currently is kind of a weird thing. It is a SQL cache, data cache and template cache and whatnot. Considering that all caches have to be able to delete files in the cache directory, shouldn't this be in the base class and consistent over all drivers?

@Nicofuma

This comment has been minimized.

Copy link
Member Author

Nicofuma commented Jul 6, 2014

A lot of things should be in the base class and not duplicated in memory and file, but I'm not sure that the 3.1 is the good place to do that.

@bantu

This comment has been minimized.

Copy link
Member

bantu commented Jul 6, 2014

@Nicofuma Deduplication is fine for 3.1. For 3.2 we should look into decoupling/decomposition.

@Nicofuma

This comment has been minimized.

Copy link
Member Author

Nicofuma commented Jul 10, 2014

updated

@Nicofuma

This comment has been minimized.

Copy link
Member Author

Nicofuma commented Jul 19, 2014

bump

@Nicofuma

This comment has been minimized.

Copy link
Member Author

Nicofuma commented Aug 8, 2014

!set WIP

@phpbb-user phpbb-user added the WIP label Aug 8, 2014

@Nicofuma

This comment has been minimized.

Copy link
Member Author

Nicofuma commented Aug 8, 2014

!unset WIP

@phpbb-user phpbb-user removed the WIP label Aug 8, 2014

@Nicofuma

This comment has been minimized.

Copy link
Member Author

Nicofuma commented Aug 8, 2014

rebased

@naderman naderman merged commit e07e9f6 into phpbb:develop-ascraeus Aug 8, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.