Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12562] Add max-width to proSilver #2682

Merged
merged 4 commits into from Jul 3, 2014

Conversation

@PayBas
Copy link
Contributor

PayBas commented Jul 1, 2014

Let's try this again.

http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=45739&start=70#p266871
https://tracker.phpbb.com/browse/PHPBB3-12562

edit: design changed, as requested.

edit 2: better screenshot
again

The response has been very positive so far.
PHPBB3-12562

PHPBB3-12562
@VSEphpbb

This comment has been minimized.

Copy link
Member

VSEphpbb commented Jul 1, 2014

A thing of beauty! Great work.

One build test errored out, needs a restart though.

padding: 15px;
}

@media only screen and (max-width: 1220px), only screen and (max-device-width: 1220px)

This comment has been minimized.

Copy link
@nickvergessen

nickvergessen Jul 3, 2014

Contributor

I think we should only hide the border when we switch to the mobile header, so we have only "2 designs" not 3

PHPBB3-12562
@PayBas

This comment has been minimized.

Copy link
Contributor Author

PayBas commented Jul 3, 2014

Screenshot updated, and switched to hanakin's version as requested.

@bantu

This comment has been minimized.

Copy link
Member

bantu commented Jul 3, 2014

The screenshot does not show any rounded corners at the bottom. Is that intentional?

@PayBas

This comment has been minimized.

Copy link
Contributor Author

PayBas commented Jul 3, 2014

No, it's just not a very good screenshot ;). They are rounded, I assure you.

@nickvergessen

This comment has been minimized.

Copy link
Contributor

nickvergessen commented Jul 3, 2014

full page screenshot
2014-07-03_15_49_40

@naderman naderman merged commit 8222eea into phpbb:develop-ascraeus Jul 3, 2014
1 check was pending
1 check was pending
continuous-integration/travis-ci The Travis CI build is in progress
Details
@VSEphpbb

This comment has been minimized.

Copy link
Member

VSEphpbb commented Jul 3, 2014

@naderman Why was this merged into ascraeus? I thought this was for 3.2, considering phpBB is now in the RC phase. Is the RC phase the time for such major cosmetic changes?

@naderman

This comment has been minimized.

Copy link
Member

naderman commented Jul 3, 2014

This is a rather important UI change which we decided was needed for marketing purposes in 3.1, so it's in ascraeus. It's also extremely unlikely to introduce bugs which would delay the RC phase.

@VSEphpbb

This comment has been minimized.

Copy link
Member

VSEphpbb commented Jul 3, 2014

OK, I'm just (still) not sure about that super light background color (I liked it better originally :/ )

@naderman

This comment has been minimized.

Copy link
Member

naderman commented Jul 3, 2014

Anything darker is just too much of a contrast distracting from the main content. Like you said it's a matter of taste I guess, so really not worth bike shedding over for ever ;-)

@PayBas PayBas deleted the PayBas:ticket/12562 branch Sep 19, 2014
@PayBas PayBas restored the PayBas:ticket/12562 branch Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.