Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12506] Reposition post-buttons for compact layout #2742

Merged
merged 4 commits into from Aug 25, 2014

Conversation

@PayBas
Copy link
Contributor

PayBas commented Jul 16, 2014

Fixes "Long post titles bump the username down an extra row beneath the edit/quote/delete buttons"

I added the .has-profile class to post because we use .post a lot, in very different contexts. Some are full (viewtopic), and some are very small/compact (post review/mcp/etc). This class will help us distinguish between "full" posts and "compact" ones.

postbuttons-abspos

https://tracker.phpbb.com/browse/PHPBB3-12506
PHPBB3-12506

@hanakin

This comment has been minimized.

Copy link
Member

hanakin commented Jul 21, 2014

Is this finished ready for testing?

@PayBas

This comment has been minimized.

Copy link
Contributor Author

PayBas commented Jul 21, 2014

Yes. Ready for testing.

}

.has-profile .post-buttons {
right: 10px;

This comment has been minimized.

Copy link
@hanakin

hanakin Jul 21, 2014

Member

This should be something like 70px to avoid overlapping online banner, similarly the .post .postprofile should only be 95% width instead of auto to avoid border overlaping

This comment has been minimized.

Copy link
@PayBas

PayBas Jul 21, 2014

Author Contributor

I actually don't like the look of moving the buttons further to the middle to make room for the "online" banner (as well as obviously taking up more space in responsive mode, which we don't want).

Not sure yet how to fix it. Perhaps reposition or change the online-styling in responsive mode.

As for the width, I'm not seeing any real problems. This would only be a problem if we had left/right borders. And even then we could probably use box-sizing.

This comment has been minimized.

Copy link
@hanakin

hanakin Jul 22, 2014

Member

changing the online banner would fix all this possibly smaller to fit the reduced header of the post

This comment has been minimized.

Copy link
@PayBas

PayBas Jul 22, 2014

Author Contributor

Fixed it. It's a bit tight, but I think it's acceptable since the online-banner has no interactions.

@hanakin

This comment has been minimized.

Copy link
Member

hanakin commented Jul 21, 2014

also unrelated but

  1. just noticed the buttons in IE9 share the same problem as the search-box changes #2504
  2. Why is the menu in responsive mode not like any of the other dropdowns? Its right aligned and their are no icons
@PayBas

This comment has been minimized.

Copy link
Contributor Author

PayBas commented Jul 21, 2014

Those points indeed aren't really related to this ticket. The hover border-color doesn't seem like a big problem since these are action buttons, not dropdowns. Only the actual responsive dropdown is a bit inconsistent with the other dropdowns... but it hardly seems worth it to add more rules for this.

As for the text positioning... the text-alignment seems a bit arbitrary, but works fine for me. There are no icons because the post buttons use the sprite instead of separate images like the other dropdowns.

@PayBas PayBas changed the title [ticket/12506] Reposition post-buttons for compact layout [WIP][ticket/12506] Reposition post-buttons for compact layout Jul 28, 2014
@PayBas PayBas changed the title [WIP][ticket/12506] Reposition post-buttons for compact layout [ticket/12506] Reposition post-buttons for compact layout Jul 28, 2014
@bantu

This comment has been minimized.

Copy link
Member

bantu commented Aug 3, 2014

@prototech Any thoughts about this patch? :-)

@prototech

This comment has been minimized.

Copy link
Contributor

prototech commented Aug 7, 2014

The behavior in the search results page is also changed which should not be the case since there are no post buttons present there.

@PayBas

This comment has been minimized.

Copy link
Contributor Author

PayBas commented Aug 7, 2014

I removed .has-profile from the search results. This fixes the problem without any fuss. But it's not completely true, because it actually does have a profile.

The alternative would be to use .has-profile.has-buttons on viewtopic_body.html and ucp_pm_viewmessage.html, but this obviously makes the CSS a bit less clean.

@bantu

This comment has been minimized.

Copy link
Member

bantu commented Aug 22, 2014

@prototech Can you please have another look?

@prototech prototech merged commit 802232c into phpbb:develop-ascraeus Aug 25, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@PayBas PayBas deleted the PayBas:ticket/12506 branch Aug 25, 2014
nickvergessen added a commit to nickv-phpbb/phpbb-ext-newspage that referenced this pull request Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.