Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Ticket/12888] Combine icons into single sprite #2774

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
4 participants
@hanakin
Copy link
Member

commented Jul 23, 2014

TODOs:

  • Fix target unread & latest unread
  • Finalize icons
  • Cleanup deprecated code

Compatability

  • Safari
  • Chrome
  • Firefox
  • IE All
  • IOS
  • Android All

PSD: https://www.dropbox.com/s/6awigiemq4kv10q/navigation-icons.psd
Ticket: https://tracker.phpbb.com/browse/PHPBB3-12888

PHPBB3-12888

@PayBas

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2014

Wow. I admire the enthusiasm with this. But this is a pretty damn big front-end change this late in the release cycle.

I'm having a hard time getting way smaller PRs than this past review and merged on time. Or is this intended for 3.2?

@hanakin

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2014

meh regardless if it gets merged our not its still something that needs done. Its all changes that need to happen before we can implement #2653 anyway. Besides its a useful way of pointing out just how inadequate our standards for coding are and the way we use JS

@nickvergessen nickvergessen changed the title [WIP] [Ticket/12888] [WIP] [Ticket/12888] Using 1 sprite file only Jul 24, 2014

@nickvergessen nickvergessen added the WIP label Jul 28, 2014

@hanakin hanakin changed the title [WIP] [Ticket/12888] Using 1 sprite file only [WIP] [Ticket/12888] Combine icons into single sprite Aug 5, 2014

@nickvergessen

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2014

A few functional tests fail and it has merge conflicts

@hanakin

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2014

It's more than that their is a lot of template vars that need rewritten and cleaned up

@phpbb-user phpbb-user added the WIP label Aug 10, 2014

@nickvergessen nickvergessen modified the milestone: 3.2.0 Oct 22, 2014

@naderman naderman force-pushed the phpbb:develop-ascraeus branch from 61ad400 to 0e772af Nov 2, 2014

@hanakin hanakin closed this Nov 18, 2014

@hanakin hanakin deleted the hanakin:ticket/12888 branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.