Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[ticket/12986] Fix detection of common words in search #2881
Conversation
phpBB/search.php
Outdated
| @@ -599,7 +598,7 @@ | |||
| 'SEARCH_MATCHES' => $l_search_matches, | |||
| 'SEARCH_WORDS' => $keywords, | |||
| 'SEARCHED_QUERY' => $search->get_search_query(), | |||
| 'IGNORED_WORDS' => (sizeof($common_words)) ? implode(' ', $common_words) : '', | |||
| 'IGNORED_WORDS' => (isset($common_words) && sizeof($common_words)) ? implode(' ', $common_words) : '', | |||
This comment has been minimized.
This comment has been minimized.
$search->get_common_words() call goes before the split_keywords() call, but $search->common_words array is being generated within the function $search->split_keywords(). Thus, get_common_words() returned an empty array instead of common words array. PHPBB3-12986
This comment has been minimized.
This comment has been minimized.
|
Updated #2881. |
bantu
added a commit
that referenced
this pull request
Aug 16, 2014
[ticket/12986] Fix detection of common words in search * rxu/ticket/12986: [ticket/12986] Fix detection of common words in search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rxu commentedAug 15, 2014
$search->get_common_words() call goes before the split_keywords() call,
but $search->common_words array is being generated
within the function $search->split_keywords(). Thus, get_common_words()
returned an empty array instead of common words array.
PHPBB3-12986.