New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/13420] Correctly filter by lt/gt/equal to 0 posts when pruning users. #3226

Merged
merged 1 commit into from Jan 20, 2015

Conversation

Projects
None yet
4 participants
@prototech
Contributor

prototech commented Dec 10, 2014

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Dec 10, 2014

Contributor

Do we have tests for this?

Contributor

nickvergessen commented Dec 10, 2014

Do we have tests for this?

@Nicofuma Nicofuma modified the milestone: 3.1.3 Dec 10, 2014

@prototech

This comment has been minimized.

Show comment
Hide comment
@prototech

prototech Dec 12, 2014

Contributor

We don't. I will add some.

Contributor

prototech commented Dec 12, 2014

We don't. I will add some.

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Jan 3, 2015

Contributor

@prototech would be nice to have it ;)

Contributor

nickvergessen commented Jan 3, 2015

@prototech would be nice to have it ;)

@@ -397,7 +397,7 @@ function get_prune_users(&$user_ids, &$usernames)
$joined_after = request_var('joined_after', '');
$active = request_var('active', '');
$count = request_var('count', 0);
$count = ($request->variable('count', '') === '') ? false : $request->variable('count', 0);

This comment has been minimized.

@Elsensee

Elsensee Jan 9, 2015

Member

Why don't you just use type casting here?

@Elsensee

Elsensee Jan 9, 2015

Member

Why don't you just use type casting here?

This comment has been minimized.

@nickvergessen

nickvergessen Jan 20, 2015

Contributor

could also try $request->variable('count', -1) ? and then check for ($count >= 0)

@nickvergessen

nickvergessen Jan 20, 2015

Contributor

could also try $request->variable('count', -1) ? and then check for ($count >= 0)

This comment has been minimized.

@nickvergessen

nickvergessen Jan 20, 2015

Contributor

okay, we use a similar mechanism already for the posts in queue:

$posts_on_queue = (trim($request->variable('posts_on_queue', '')) === '') ? false : $request->variable('posts_on_queue', 0);

so I guess its fine?

@nickvergessen

nickvergessen Jan 20, 2015

Contributor

okay, we use a similar mechanism already for the posts in queue:

$posts_on_queue = (trim($request->variable('posts_on_queue', '')) === '') ? false : $request->variable('posts_on_queue', 0);

so I guess its fine?

nickvergessen added a commit to nickvergessen/phpbb that referenced this pull request Jan 20, 2015

Merge pull request phpbb#3226 from prototech/ticket/13420
[ticket/13420] Correctly filter by lt/gt/equal to 0 posts when pruning users.

@nickvergessen nickvergessen merged commit 75780d7 into phpbb:develop-ascraeus Jan 20, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@nickvergessen nickvergessen removed the WIP 🚧 label Jan 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment