New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/12559] Add forum setting to limit subforums legend to direct children only #3386

Closed
wants to merge 4 commits into
base: develop
from

Conversation

Projects
None yet
4 participants
@PayBas
Contributor

PayBas commented Feb 9, 2015

https://tracker.phpbb.com/browse/PHPBB3-12559
http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=45585
PHPBB3-12559

Actually, adding this as an option for categories in the ACP module is very tricky. There isn't really any place for a unique setting that is shared by forums & categories, but not links. We can't simply duplicate form components for obvious reasons, and introducing yet another table column for categories which does exactly the same thing as the forum version... that's just silly.

So I'm going to leave it as is. If admins really want to limit subforums for categories, they can change the forum type to "forum", change the setting, and change the type back to "category".

Not ideal, but it's the cleanest way, code-wise.

Copied from the original PR #2473

please rebase onto develop and replace your request_var() calls by $request->variable()

Done

@nickvergessen nickvergessen added this to the 3.2.0 milestone Feb 20, 2015

@Nicofuma

This comment has been minimized.

Show comment
Hide comment
@Nicofuma

Nicofuma Jul 3, 2015

Member

I don't remember why the PR wasn't merged, @nickvergessen any clue?

Member

Nicofuma commented Jul 3, 2015

I don't remember why the PR wasn't merged, @nickvergessen any clue?

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Jul 3, 2015

Contributor

Needs proper testing, nothing more?

Contributor

nickvergessen commented Jul 3, 2015

Needs proper testing, nothing more?

@Nicofuma Nicofuma modified the milestones: 3.2.0-a1, 3.2.0-a2 Oct 17, 2015

@Nicofuma Nicofuma modified the milestones: 3.2.0-a2, 3.2.0-a3 Dec 19, 2015

@Nicofuma Nicofuma modified the milestones: 3.2.0-b1, 3.2.0-b2 Feb 4, 2016

@Nicofuma Nicofuma modified the milestones: 3.2.0-b2, 3.2.0-b3 Mar 7, 2016

@Nicofuma Nicofuma closed this Apr 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment