Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/13493] Append page name to base url if it doesn't contain it #3392

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@marc1706
Copy link
Member

commented Feb 11, 2015

@Nicofuma

This comment has been minimized.

Copy link
Member

commented Mar 24, 2015

I'm not sure that I agree with this PR. We should have at least one test failing without it

@marc1706

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2015

The test I added should fail if you remove the change to the controller helper.

@marc1706

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2015

Right now this causes a rather bad issue. If you do not have mod rewrite enabled and access the website. for example via http://example.com, and click on an extension link the URL will be missing app.php. This will obviously causes 404 errors.

@nickvergessen nickvergessen modified the milestones: 3.1.5, 3.1.4 Apr 4, 2015

@marc1706 marc1706 removed the WIP 🚧 label Apr 6, 2015

@nickvergessen nickvergessen modified the milestones: 3.1.4, 3.1.5 Apr 6, 2015

nickvergessen added a commit to nickvergessen/phpbb that referenced this pull request Apr 6, 2015

Merge pull request phpbb#3392 from marc1706/ticket/13493
[ticket/13493] Append page name to base url if it doesn't contain it
@nickvergessen

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2015

Merged via http://git.io/veRC0

@marc1706 marc1706 deleted the marc1706:ticket/13493 branch Apr 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.