Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket/8116 Add pagination for IP tables on post info #3456

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
5 participants
@nickvergessen
Copy link
Contributor

commented Feb 28, 2015

@nickvergessen nickvergessen added this to the 3.1.4 milestone Feb 28, 2015

[ticket/8116] Fix Queries
PHPBB3-8116

@nickvergessen nickvergessen removed the WIP 🚧 label Feb 28, 2015

* @param string $poster_ip
* @return int
*/
function phpbb_get_num_posters_for_ip(\phpbb\db\driver\driver_interface $db, $poster_ip)

This comment has been minimized.

Copy link
@nickvergessen

nickvergessen Feb 28, 2015

Author Contributor

could try to deduplicate these methods, but without putting the column name directly into the query string, you loose the overview on them

*/
function phpbb_get_num_posters_for_ip(\phpbb\db\driver\driver_interface $db, $poster_ip)
{
if ($db->get_sql_layer() == 'sqlite' || $db->get_sql_layer() == 'sqlite3')

This comment has been minimized.

Copy link
@bantu

bantu Mar 1, 2015

Member

This construction should be in DBAL instead.

if ($db->get_sql_layer() == 'sqlite' || $db->get_sql_layer() == 'sqlite3')
{
$sql = 'SELECT COUNT(poster_id) as num_users
FROM (SELECT DISTINCT poster_id';

This comment has been minimized.

Copy link
@bantu

bantu Mar 1, 2015

Member

"(" is never closed?

@@ -341,6 +355,23 @@ function mcp_post_details($id, $mode, $action)
}
$db->sql_freeresult($result);
if ($users == $config['posts_per_page'] || $start_users)

This comment has been minimized.

Copy link
@bantu

bantu Mar 1, 2015

Member

The difference between $users and $num_users is not clear.

@bantu bantu added the WIP 🚧 label Mar 4, 2015

@nickvergessen nickvergessen modified the milestones: 3.1.5, 3.1.4 Apr 3, 2015

@marc1706 marc1706 modified the milestones: 3.1.6, 3.1.5 Jun 9, 2015

@Nicofuma Nicofuma modified the milestones: 3.1.6, 3.1.7 Sep 5, 2015

@nickvergessen nickvergessen modified the milestones: 3.1.7, 3.1.8 Dec 13, 2015

@nickvergessen nickvergessen modified the milestones: 3.1.8, 3.1.9 Feb 13, 2016

@Nicofuma Nicofuma removed this from the 3.1.9 milestone Apr 12, 2016

@Nicofuma Nicofuma modified the milestones: 3.1.10, 3.1.9 Apr 12, 2016

@marc1706 marc1706 modified the milestones: 3.1.11, 3.1.10 Sep 24, 2016

@marc1706 marc1706 modified the milestones: 3.1.12, 3.1.11 Jan 4, 2017

@CHItA

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

I'm closing this, as a present for this PR's second birthday.

@CHItA CHItA closed this Feb 28, 2017

@nickvergessen nickvergessen deleted the nickvergessen:ticket/8116 branch Mar 1, 2017

@Nicofuma Nicofuma modified the milestone: 3.1.12 Mar 20, 2017

@marc1706 marc1706 referenced this pull request Mar 29, 2017

Merged

[ticket/8116] Add pagination for IP tables and post info #4780

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.