Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/13759] Take post_time into account #3538

Merged
merged 1 commit into from Jun 24, 2015

Conversation

@rmcgirr83
Copy link
Contributor

rmcgirr83 commented Apr 16, 2015

when using the submit_post function

PHPBB3-13759

@rmcgirr83

This comment has been minimized.

Copy link
Contributor Author

rmcgirr83 commented Apr 16, 2015

PHPBB3-13759
@Nicofuma

This comment has been minimized.

Copy link
Member

Nicofuma commented Jun 8, 2015

👍

@rmcgirr83

This comment has been minimized.

Copy link
Contributor Author

rmcgirr83 commented Jun 8, 2015

☝️

@nickvergessen nickvergessen modified the milestones: 3.1.5, 3.1.6 Jun 11, 2015
marc1706 added a commit to marc1706/phpbb that referenced this pull request Jun 24, 2015
[ticket/13759] Take post_time into account
@marc1706 marc1706 merged commit a53b57c into phpbb:3.1.x Jun 24, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmcgirr83 rmcgirr83 deleted the rmcgirr83:ticket/13759 branch Jun 24, 2015
@nickvergessen

This comment has been minimized.

Copy link
Contributor

nickvergessen commented Jun 27, 2015

@rxu

This comment has been minimized.

Copy link
Contributor

rxu commented Jun 27, 2015

Probably can be fixed just by excluding the quote mode

if ($mode != 'quote' && !empty($data['post_time']))
@nickvergessen

This comment has been minimized.

Copy link
Contributor

nickvergessen commented Jun 27, 2015

and edit, and ... ?

@nickvergessen

This comment has been minimized.

Copy link
Contributor

nickvergessen commented Jun 27, 2015

Or just dont send in post_time to submit_post in our calls

@rmcgirr83

This comment has been minimized.

Copy link
Contributor Author

rmcgirr83 commented Jun 28, 2015

Editing passes the posts time as well. Not sure about all the other modes though. Reply doesn't seem to. It's a bit odd that there is this line in posting.php prior to the submit_post function

'post_time' => (isset($post_data['post_time'])) ? (int) $post_data['post_time'] : $current_time,

but then $current_time is used as default in submit_post function and I can't see where $data['post_time'] is ever used.

@rmcgirr83 rmcgirr83 restored the rmcgirr83:ticket/13759 branch Jun 28, 2015
@rmcgirr83

This comment has been minimized.

Copy link
Contributor Author

rmcgirr83 commented Jun 30, 2015

Any comment from anyone?

@nickvergessen

This comment has been minimized.

Copy link
Contributor

nickvergessen commented Jun 30, 2015

Well I guess if you make sure this is really not the case, you can remove it, so it is not injected by default?

@rmcgirr83

This comment has been minimized.

Copy link
Contributor Author

rmcgirr83 commented Jul 1, 2015

I tested pretty extensively (soft delete, edit, reply, quote, etc) if $data doesn't have post_time within it and ran across no issues. So should I amend this ticket or start a new one (will require new ticket in tracker?).

Would you prefer the code be commented out or completely removed?

@marc1706

This comment has been minimized.

Copy link
Member

marc1706 commented Jul 1, 2015

I'd recommend you remove the line if it's really not needed and properly explain why this was done in the commit message.

@rmcgirr83

This comment has been minimized.

Copy link
Contributor Author

rmcgirr83 commented Jul 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.