[ticket/13847] Move quote generation to text_formatter.utils #3616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $message_parser->message = '[quote="' . $post_data['quote_username'] . '"]' . censor_text(trim($message_parser->message)) . "[/quote]\n"; | ||
| $message_parser->message = $phpbb_container->get('text_formatter.utils')->generate_quote( | ||
| censor_text(trim($message_parser->message)), | ||
| array('author' => $post_data['quote_username']) |
There was a problem hiding this comment.
couldn't we generate the quote with a link to the user profile?
There was a problem hiding this comment.
Yes. You can put as much metadata as you want, and then use it in the template. I'm wary of overloading the UI though. There's a topic about possible quote improvements on A51.
JoshyPHP
force-pushed
the
ticket/13847
branch
2 times, most recently
from
00e1bab
to
43ee388
Compare
|
@Nicofuma Can you merge this PR whenever you have time please? Other PRs will depend on it and since most of my PRs modify more or less the same files I'm getting conflicts when merging/rebasing. |
Will enclose attribute values in single- or double- quotes depending on whichever requires the least escaping. Characters that need to be escaped are always escaped regardless. PHPBB3-13847
...when quoting a post PHPBB3-13847
Nicofuma
pushed a commit
that referenced
this pull request
May 29, 2015
[ticket/13847] Move quote generation to text_formatter.utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.phpbb.com/browse/PHPBB3-13847
The markup used for quotes,
[quote=".."]...[/quote]is currently hardcoded in posting.php. This could be moved to a method in thetext_formatter.utilsservice.Ultimately, anything that manipulates markup should live in a
text_formatter.*service.