New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11530] Remove extra quotes when depth limit is exceeded #3617

Merged
merged 3 commits into from May 19, 2015

Conversation

Projects
None yet
2 participants
@JoshyPHP
Contributor

JoshyPHP commented May 18, 2015

https://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=42779
https://tracker.phpbb.com/browse/PHPBB3-11530

Removes extra quotes before populating the posting form.
Removes extra quotes in the submitted text.
One caveat: does not remove extra quotes in the posting form if the quoted post is from the old parser. Fixes itself on preview.

@Nicofuma Nicofuma added the 3.2 (Rhea) label May 19, 2015

@Nicofuma Nicofuma added this to the 3.2.0 milestone May 19, 2015

@@ -71,4 +71,85 @@ public function test_html_entities()
$crawler = self::request('GET', "viewtopic.php?t={$post['topic_id']}&sid={$this->sid}");
$this->assertContains('😀', $crawler->text());
}
/**
* @testdox max_quote_depth is applied to the text populating the posting form

This comment has been minimized.

@Nicofuma

Nicofuma May 19, 2015

Member

@testdox ?

@Nicofuma

Nicofuma May 19, 2015

Member

@testdox ?

This comment has been minimized.

@JoshyPHP

JoshyPHP May 19, 2015

Contributor

A description of the test as a declarative sentence, because it's hard to tell what is being tested just by looking at the code. It can also be used to generate nice checklists like this one.

@JoshyPHP

JoshyPHP May 19, 2015

Contributor

A description of the test as a declarative sentence, because it's hard to tell what is being tested just by looking at the code. It can also be used to generate nice checklists like this one.

@Nicofuma Nicofuma merged commit 2cc78b2 into phpbb:master May 19, 2015

Nicofuma added a commit that referenced this pull request May 19, 2015

Merge pull request #3617 from s9e/ticket/11530
[ticket/11530] Remove extra quotes when depth limit is exceeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment