Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/13876] Use webfontloader asyncronously. #3640

Merged
merged 2 commits into from May 28, 2015

Conversation

@callumacrae
Copy link
Contributor

callumacrae commented May 28, 2015

This PR adds typekit and Google's webfontloader and calls it
asyncronously, removing the SPOF in the header. Now, if google
goes down, some buttons display with a different font.

https://github.com/typekit/webfontloader

https://tracker.phpbb.com/browse/PHPBB3-13876

This PR adds typekit and Google's webfontloader and calls it
asyncronously, removing the SPOF in the header. Now, if google
goes down, some buttons display with a different font.

https://github.com/typekit/webfontloader

PHPBB3-13876
@callumacrae callumacrae force-pushed the callumacrae:ticket/13876 branch from 5a212fc to 35e5dc4 May 28, 2015
@marc1706

This comment has been minimized.

Copy link
Member

marc1706 commented May 28, 2015

Is there a reason we shouldn't be using https://ajax.googleapis.com/ajax/libs/webfont/1/webfont.js instead of fixing it at 1.5.8?

@marc1706

This comment has been minimized.

Copy link
Member

marc1706 commented May 28, 2015

Also, don't you need to set wf.async = 'true';?

@callumacrae

This comment has been minimized.

Copy link
Contributor Author

callumacrae commented May 28, 2015

1/ has a shorter cache time, which is why I'm not using it. I'll set async to true.

PHPBB3-13876
@callumacrae

This comment has been minimized.

Copy link
Contributor Author

callumacrae commented May 28, 2015

Done

marc1706 added a commit to marc1706/phpbb that referenced this pull request May 28, 2015
[ticket/13876] Use webfontloader asyncronously.
@marc1706 marc1706 merged commit 44fcdd0 into phpbb:3.1.x May 28, 2015
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@callumacrae callumacrae deleted the callumacrae:ticket/13876 branch May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.