[ticket/10362] HTML5 Fix - Replace name attribute with id in anchors #367

Merged
merged 2 commits into from Sep 21, 2011

3 participants

@VSEphpbb
phpBB Forum Software member

When validating for HTML5, the "name" attribute is obsolete/deprecated when used in anchor tags. The ID tag should be used here instead. The ID works just as NAME did, as an in-line anchor target in all browsers (even IE6) to jump to a part of the page from a link, such as href="#some_id_target".

Fixes here are for pro silver, subsilver2 and the ACP styles.

Issue here http://tracker.phpbb.com/browse/PHPBB3-10362

@igorw

The ticket id needs to be on a separate line at the end of the commit message. Also note the blank lines.

[ticket/12345] foobar

body

PHPBB3-12345

@VSEphpbb
phpBB Forum Software member

Yeah, it got botched up. I'm trying to figure out how to change it.

@igorw

Looks good.

@p
p commented Sep 11, 2011

The commit message now exceeds 79 chars horizontally.

@VSEphpbb VSEphpbb [ticket/10362] HTML5 Fix - Replace name attribute with id in anchors
When validating for HTML5, the name attribute is obsolete/deprecated
when used in anchor tags. The ID tag should be used here instead.

PHPBB3-10362
3f61075
@VSEphpbb
phpBB Forum Software member

OK fixed that

@p
p commented Sep 13, 2011

Looks good, I think. If there are no objections I think it is ready for merging.

@p
p commented Sep 13, 2011

Actually, if we're going to revert to xhtml1 for subsilver, do we want to edit it here?

@VSEphpbb
phpBB Forum Software member

The changes made to subsilver2 here will not matter if it is going to be HTML5 or XHTML. They are valid for both doctypes.

@p
p commented Sep 14, 2011

That is true but we don't want to make changes we don't have to due to modifications.

@VSEphpbb VSEphpbb [ticket/10362] Revert subsilver2 changes
If subsilver2 will remain at XHTML then we do not need to make any
changes to its files.

PHPBB3-10362
b8da683
@igorw igorw merged commit b8da683 into phpbb:develop Sep 21, 2011
@VSEphpbb VSEphpbb deleted the VSEphpbb:ticket/10362 branch Jun 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment