Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ticket/14131] Completely overhaul all colors in Colours.css #3867

Closed
wants to merge 20 commits into from

Conversation

@hanakin
Copy link
Member

hanakin commented Aug 30, 2015

Completely overhaul all colors in Colours.css to be consistent and standardized. Match all colors to a color styleguide using set color variables.

Tracker: https://tracker.phpbb.com/browse/PHPBB3-14131

PHPBB3-14131

@Zoddo

This comment has been minimized.

Copy link
Contributor

Zoddo commented Aug 30, 2015

@hanakin hanakin changed the title Ticket/14131Completely overhaul all colors in Colours.css [Ticket/14131] Completely overhaul all colors in Colours.css Aug 30, 2015
@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Aug 30, 2015

Ready for review!

@Nicofuma Nicofuma modified the milestone: 3.2.0-a1 Sep 1, 2015
@Nicofuma Nicofuma added the 3.2 (Rhea) label Sep 1, 2015
@Nicofuma

This comment has been minimized.

Copy link
Member

Nicofuma commented Sep 1, 2015

I guess that not every browser supports this feature, right? What about the one we officially support?

@Nicofuma

This comment has been minimized.

Copy link
Member

Nicofuma commented Sep 1, 2015

Well actually, I don't really understand what you are doing... just cleaning up the formatting and some weird color definitions?

@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Sep 1, 2015

Nothing is supported by a browser those are just the variables I used when I fixed all the incorrect colors in the theme which is the main purpose of this. I removed all the slight variances and replaced all the incorrect colors with the proper ones based on the standardized guide in the comments. I left the comments in for documentation purposes on what colors to use in what situations. Overall reducing the total number of colors in half going from over 100 colors to just over 50

@Nicofuma

This comment has been minimized.

Copy link
Member

Nicofuma commented Sep 1, 2015

ok, thanks.

By the way, you need to rebase (it conflicts with another of your PRs)

@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Sep 1, 2015

yeah working that now there is alot of manual review lol

@Nicofuma

This comment has been minimized.

Copy link
Member

Nicofuma commented Sep 1, 2015

@cyberalien Again, could you have a look please? (Yes, there is a lot of styling PRs these days :-))

background-color: #F5F7FA;
}

h1 {
color: #FFFFFF;
h1 {

This comment has been minimized.

Copy link
@marc1706

marc1706 Sep 12, 2015

Member

Trailing whitespace should be removed

@marc1706

This comment has been minimized.

Copy link
Member

marc1706 commented Sep 12, 2015

Your PR seems to contain a lot of trailing whitespace. They're nicely highlighted by github, too.

@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Sep 13, 2015

@marc1706 yeah have not really done much work on as every merge affects it drastically it going to have to go as the last merge anyway. So its best to fix it all during the long dynamic rebase

@phpbb-user phpbb-user added the WIP 🚧 label Sep 13, 2015
@cyberalien

This comment has been minimized.

Copy link
Contributor

cyberalien commented Sep 16, 2015

Sorry for delay. Color changes look good.

@Zoddo

This comment has been minimized.

Copy link
Contributor

Zoddo commented Sep 27, 2015

@hanakin : You need to add PHPBB3-14131 at the end of each commit message for the tracker.

@Nicofuma Nicofuma modified the milestones: 3.2.0-a1, 3.2.0-a2 Oct 17, 2015
@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Nov 11, 2015

ready for review @cyberalien

@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Nov 17, 2015

ready for review @prototech should not be any BC issues just helping to standardize colours.

@VSEphpbb

This comment has been minimized.

Copy link
Member

VSEphpbb commented Nov 17, 2015

Umm,forum background color is awful. Please revert that. There's just a weird wash of blue-i-ness to this that makes phpBB uglier.

@Nicofuma Nicofuma modified the milestones: 3.2.0-a3, 3.2.0-a2 Dec 19, 2015
@Nicofuma Nicofuma modified the milestone: 3.2.0-a3 Jan 24, 2016
@CHItA CHItA added this to the 3.3.0-a1 milestone Feb 28, 2016
@hanakin hanakin closed this Feb 12, 2017
@hanakin hanakin removed this from the 4.0.0-a1 milestone Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.