Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/13716] Check phpBB version constant against config version #3901

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@Zoddo
Copy link
Contributor

commented Sep 12, 2015

On the ACP display a warning if the version constant (files) does not
match the phpbb_config version (often indicating that the database updater
hasn't been run)

PHPBB3-13716

@Zoddo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2015

It's possible that the text contains some formulation and typo errors (the english isn't that in which I'm better).

@Nicofuma Nicofuma added this to the 3.1.7 milestone Sep 12, 2015

@@ -439,6 +440,7 @@
'FILES_NOT_MODIFIED_EXPLAIN' => 'The following files are not modified and represent the original phpBB files from the version you want to update from.',
'FILES_UP_TO_DATE' => 'Already updated files',
'FILES_UP_TO_DATE_EXPLAIN' => 'The following files are already up to date and do not need to be updated.',
'FILES_VERSION' => 'Files version',

This comment has been minimized.

Copy link
@VSEphpbb

VSEphpbb Sep 12, 2015

Member

Files version doesn't sound right. Either "Package version" or "Package version installed"

I would also use PACKAGE_VERSION instead of FILES_VERSION here and elsewhere.

@@ -530,6 +532,27 @@
'UPDATE_DATABASE_SCHEMA' => 'Updating database schema',
'UPDATE_FILES' => 'Update files',
'UPDATE_FILES_NOTICE' => 'Please make sure you have updated your board files too, this file is only updating your database.',
'UPDATE_INCOMPLETE' => 'Your phpBB installation has not been correctly updated.',

This comment has been minimized.

Copy link
@VSEphpbb

VSEphpbb Sep 12, 2015

Member

All of this here seems like a verbose mess of information not really needed. All you are checking is if the db version is < the package version. If that's true, all that means is the user needs to run the database update script. So just provide a link to the update script at root/install/database_update.php.

All these links and a re-explanation of how to do updates here is too much.

This comment has been minimized.

Copy link
@VSEphpbb

VSEphpbb Sep 13, 2015

Member

Like instead of all that, just explain that it appears the database has not yet been updated...here's the link to do so...

This comment has been minimized.

Copy link
@Zoddo

Zoddo Sep 13, 2015

Author Contributor

All of this here seems like a verbose mess of information not really needed.

Why don't write an explicative text? This can be benefit for administrators that don't have much knowledge of phpBB. Or there is some reason to not include this text?

So just provide a link to the update script at root/install/database_update.php

Yes, but the install folder may have been deleted and some administrators can be novice, so I think that we need to explain to the user, the complete way to retrieve the archive and finish the update.

This comment has been minimized.

Copy link
@VSEphpbb

VSEphpbb Sep 13, 2015

Member

This will only appear to somebody who has already downloaded and installed the latest package. So re-explaining to them where and how to get the latest package is redundant and could confuse overwhelm newbies.

If the user deleted their install folder, they will get an error that database_update couldn't be found. So all you have to explain here is that users should visit the database_update script, and if it is missing, they should download their package version from phpbb.com again, upload the install folder, and then visit the script.

This comment has been minimized.

Copy link
@Nicofuma

Nicofuma Oct 12, 2015

Member

bump, whats up here?

This comment has been minimized.

Copy link
@Zoddo

Zoddo Oct 12, 2015

Author Contributor

So delete extras informations and just keep a short text that say to run database_update?

This comment has been minimized.

Copy link
@Nicofuma

Nicofuma Oct 12, 2015

Member

to run database_update or the cli command yes

[ticket/13716] Check phpBB version constant against config version
On the ACP display a warning if the version constant (files) does not
match the phpbb_config version (often indicating that the database updater
hasn't been run)

PHPBB3-13716

@Zoddo Zoddo force-pushed the Zoddo:ticket/13716 branch from ab225c1 to 7e8e2c8 Sep 13, 2015

<dl>
<dt><label>{L_CURRENT_VERSION}</label></dt>
<dd><strong>{CURRENT_VERSION}</strong></dd>
</dl>
<!-- ELSE -->
<dl>
<dt><label>{L_FILES_VERSION}</label></dt>

This comment has been minimized.

Copy link
@Nicofuma

Nicofuma Oct 12, 2015

Member

This language string is missing

This comment has been minimized.

Copy link
@Nicofuma

This comment has been minimized.

Copy link
@Nicofuma

Nicofuma Mar 25, 2016

Member

@Zoddo bump again

@marc1706

This comment has been minimized.

Copy link
Member

commented Apr 7, 2016

Closing as there is now #4281

@marc1706 marc1706 closed this Apr 7, 2016

@Zoddo Zoddo deleted the Zoddo:ticket/13716 branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.