Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/14193]Fix secondary buttons #3932

Merged
merged 2 commits into from Oct 7, 2015

Conversation

@hanakin
Copy link
Member

hanakin commented Sep 27, 2015

@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Sep 28, 2015

@VSEphpbb please review

@VSEphpbb

This comment has been minimized.

Copy link
Member

VSEphpbb commented Sep 28, 2015

Unfortunately, this has changed a lot of button icons red. Advanced search, New Topic for example. That looks wrong/bad.

screen shot 2015-09-28 at 2 07 50 pm

Also, text inside of the message editor has been turned blue!?! It should be black.

The custom BBCode buttons look good though. Except for one issue. They should have some top/bottom spacing. If you have a lot of bbcodes, and they wrap down a line, the buttons touch.

screen shot 2015-09-28 at 2 05 40 pm

@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Sep 28, 2015

yeah these are all kind of wipish as I am trying to muddle through splitting up 14197

@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Sep 29, 2015

hmm @VSEphpbb can not reproduce the red icon issue on my end maybe a cache thing? but try everything now

@VSEphpbb

This comment has been minimized.

Copy link
Member

VSEphpbb commented Sep 29, 2015

Issues are cleared up, but this seems like a lot of "other" changes just to fix the custom bbcode buttons.

Can't you just make a fixer class for the bbcode buttons only, rather than having made a change that seems to be affecting other buttons and resulting in this awkward "button-icon-only" class being added in so many places? Just a thought.

@hanakin

This comment has been minimized.

Copy link
Member Author

hanakin commented Sep 29, 2015

well the fix for the bbcode button is simply the button-secondary class I could break it up into separate prs if absolutely necessary one for the button-secondary and one for the extra spacing between rows

@CHItA CHItA added this to the 3.2.0-a1 milestone Sep 29, 2015
@hanakin hanakin closed this Oct 1, 2015
hanakin added 2 commits Oct 3, 2015
PHPBB3-14193
@hanakin hanakin reopened this Oct 3, 2015
@Nicofuma Nicofuma added the 3.2 (Rhea) label Oct 4, 2015
marc1706 added a commit to marc1706/phpbb that referenced this pull request Oct 7, 2015
[ticket/14193]Fix secondary buttons
@marc1706 marc1706 merged commit 8907a66 into phpbb:master Oct 7, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hanakin hanakin deleted the hanakin:ticket/14193 branch May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.