Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

WIP: [feature/ckeditor] Use CKEditor for posting posts #433

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
4 participants
Owner

naderman commented Oct 17, 2011

Please always put the ticket id (PHPBB3-10418 in this case) into the last line of your commit message - this is used to link up commits with bamboo builds. See: http://wiki.phpbb.com/Git#Commit_Messages

Owner

naderman commented Oct 17, 2011

Please start a discussion on area51 about including external projects in phpBB, cause we won't be commiting the entirety of ckeditor into the phpBB source tree. We need to find a general solution for reusing 3rd party libraries both on the PHP and js level.

Owner

naderman commented Oct 17, 2011

We should also discuss support for custom BBCodes, in particular if we are going to switch out the bbcode class for 3.1 still and won't have any hard coded BBCodes anymore.

wGEric added some commits Oct 17, 2011

[feature/ckeditor] Adding CKEditor as a WYSIWYG editor for posts.
* Users can set in the UCP whether to use the WYSIWYG editor or not
* Can toggle between modes on the posting screen

PHPBB3-10418
[feature/ckeditor] Move files around in CKEditor to make it easier to…
… configure

* Config is now in a different file then the one provided by CKEditor. This
makes it easier to update CKEditor.
* Themes can define/create skins for the editor

PHPBB3-10418
[feature/ckeditor] Renaming to rich text editor
That is a more accurate name since it probably won't be a true WYSIWYG.

PHPBB3-10418
Contributor

igorw commented Oct 29, 2011

There's still quite some work ahead, but this quite impressive!

wGEric added some commits Oct 29, 2011

Merge branch 'develop' of git://github.com/phpbb/phpbb3 into feature/…
…ckeditor

Conflicts:
	phpBB/styles/prosilver/template/overall_footer.html
[feature/ckeditor] Adding smiley support to richtext editor
Started a phpbb plugin so reverted the bbcode one back to the original.

PHPBB3-10418
Contributor

p commented Nov 11, 2011

This pull request is essentially unviewable in firefox (3.6). Please completely annihilate everything that is part of ckeditor via rebasing.

Eric Faerber added some commits Nov 16, 2011

[feature/ckeditor] Updates to make plugins work outside of CKEditor's…
… path

CKEditor should now be completely separate from phpBB's source.

PHPBB3-10418

@wGEric wGEric closed this Nov 21, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment