New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/15009] Inconsistency all_configured all_available #4644

Closed
wants to merge 244 commits into
base: master
from

Conversation

Projects
None yet
@javiexin
Contributor

javiexin commented Jan 14, 2017

PHPBB3-15009

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-15009

senky and others added some commits Nov 20, 2016

[ticket/14849] Add core.acp_extensions_run_action
Moved the event to a slightly modified position to perform common
checks before calling the event, added an extra variable to allow
execution control, honor the extension modified value of u_action
(if any)

PHPBB-14849
[ticket/14849] Add core.acp_extensions_run_action_after
Additional event to be run after the execution of the action in ACP

PHPBB-14849
[ticket/14849] Add core.acp_extensions_run_action_after
Additional event to be run after the execution of the action in ACP.
Adding missing var as input to event.

PHPBB-14849
[ticket/14919] Do not directly use globals in acp_extensions
Declare all used variables (u_action, tpl_name, page_title).

PHPBB3-14919
[ticket/14919] Do not directly use globals in acp_extensions
Declare all used variables (u_action, tpl_name, page_title). Fix typo.

PHPBB3-14919
[ticket/14938] Inconsistency in ext_mgr all_available vs is_available
Made is_available much more strict, in line with the checks in all_available

PHPBB3-14938
[ticket/14944] Add possibility to search for template loop indexes by…
… key

Adds a new function to the template interface, and implements it in the
context class.  The function returns the ordinal index for a specified key,
with the same structure that the key for alter_block_array.
Reuses same code.

PHPBB3-14944
[ticket/14944] Add possibility to search for template loop indexes by…
… key

Adds a new function to the template interface, and implements it in the
context class.  The function returns the ordinal index for a specified key,
with the same structure that the key for alter_block_array.
Reuses same code. Remove unneeded references, do nothing for int keys.

PHPBB3-14944
[ticket/14849] Add core.acp_extensions_run_action
Moved the event to a slightly modified position.
Added an extra variable to the event.
Additional event to be run after the execution of the action in ACP.
Added a new action to allow for extension execution control.

PHPBB-14849
[ticket/14938] Inconsistency in ext_mgr all_available vs is_available
Made is_available much more strict, in line with the checks in all_available
Refactor all_available to use is_available, saving duplicate code.

PHPBB3-14938
[ticket/14943] Fix template loop access by index
Allows inserting elements in a loop specified as 'outer[3].inner'.
This was coded, but malfunctioning.  Name incorrectly set on insert.

PHPBB3-14943
[ticket/14950] Add possibility to delete a template block
Adds a new mode to alter_block_array to allow for the deletion of
a certain block of template variables.  The selection method is the
same as for the other modes for alter_block_array.  The passed in
vararray is ignored, and an out of bounds index is considered an error.

PHPBB3-14944
[ticket/14943] Fix template loop access by index
Allows inserting elements in a loop specified as 'outer[3].inner'.
This was coded, but malfunctioning.  Name incorrectly set on insert.
Added tests.

PHPBB3-14943
[ticket/14943] Fix template loop access by index
Allows inserting elements in a loop specified as 'outer[3].inner'.
This was coded, but malfunctioning.  Name incorrectly set on insert.
Added more tests.

PHPBB3-14943
[ticket/14950] Add possibility to delete a template block
Adds a new mode to alter_block_array to allow for the deletion of
a certain block of template variables.  The selection method is the
same as for the other modes for alter_block_array.  The passed in
vararray is ignored, and an out of bounds index is considered an error.
Added tests for the new function.

PHPBB3-14950
[ticket/14944] Add possibility to search for template loop indexes by…
… key

Adds a new function to the template interface, and implements it in the
context class.  The function returns the ordinal index for a specified key,
with the same structure that the key for alter_block_array.
Reuses same code. Remove unneeded references, do nothing for int keys.
Check out of bounds or wrong blockname errors.  Added tests.

PHPBB3-14944
[ticket/14950] Add possibility to delete a template block
Adds a new mode to alter_block_array to allow for the deletion of
a certain block of template variables.  The selection method is the
same as for the other modes for alter_block_array.  The passed in
vararray is ignored, and an out of bounds index is considered an error.
Added tests for the new function, fixed.

PHPBB3-14950
[ticket/14950] Add possibility to delete a template block
Adds a new mode to alter_block_array to allow for the deletion of
a certain block of template variables.  The selection method is the
same as for the other modes for alter_block_array.  The passed in
vararray is ignored, and an out of bounds index is considered an error.
Added tests for the new function, fixed.

PHPBB3-14950
[ticket/14950] Add possibility to delete a template block
Adds a new mode to alter_block_array to allow for the deletion of
a certain block of template variables.  The selection method is the
same as for the other modes for alter_block_array.  The passed in
vararray is ignored, and an out of bounds index is considered an error.
Added tests for the new function, fixed.

PHPBB3-14950
[ticket/14975] Correct RTL style css
display_options.html corrected to move (display and sorting option) to right
jumpbox.html corrected to change arrow direction to left in RTL
pagination.html corrected to change arrows direction on RTL
bidi.css more edittions to correct remain style mistakes

PHPBB3-14975
[ticket/14943] Fix template loop access by index
Allows inserting elements in a loop specified as 'outer[3].inner'.
This was coded, but malfunctioning.  Name incorrectly set on insert.
If block was empty, the insertion process should create it.
Checking for out of bounds indexes.

PHPBB3-14943
[ticket/14950] Add possibility to delete a template block
Adds a new mode to alter_block_array to allow for the deletion of
a certain block of template variables.  The selection method is the
same as for the other modes for alter_block_array.  The passed in
vararray is ignored, and an out of bounds index is considered an error.
Added tests for the new function, fixed.

PHPBB3-14950

Nicofuma and others added some commits Apr 18, 2017

Merge pull request #4705 from nomind60s/ticket/15097
[ticket/15097] Add PHP version to Board statistics

* github.com:phpbb/phpbb:
  [ticket/15097] New 'Installed software' lead section
  [ticket/15097] Resolve travis-ci error
  [ticket/15097] Resolve travis-ci error
  [ticket/15097] Add PHP version to Board statistics
  [ticket/15097] Add PHP version to Board statistics
Merge pull request #4693 from marc1706/ticket/15079
[ticket/15079] Parse message before inserting it into drafts table

* github.com:phpbb/phpbb:
  [ticket/15079] Parse message before inserting it into drafts table
Merge pull request #4692 from rubencm/ticket/15084
[ticket/15084] Fix wrong order of breadcrumbs in module management

* github.com:phpbb/phpbb:
  [ticket/15084] fix wrong order of breadcrumbs on module management
Merge pull request #4788 from JoshyPHP/ticket/15163
fixes #4788

* ticket/15163:
  [ticket/15163] Escape curly braces in smilies HTML attributes
Merge pull request #4796 from marc1706/ticket/15174
	[ticket/15174] Increase timeout for loading indicator

* github.com:phpbb/phpbb:
  [ticket/15174] Split timeout message to extra method and set timeout to 60s
  [ticket/15174] Increase timeout for loading indicator
Merge branch '3.1.x' into 3.2.x
* 3.1.x:
  [ticket/15174] Split timeout message to extra method and set timeout to 60s
  [ticket/15174] Increase timeout for loading indicator
Merge pull request #4792 from Louis7777/ticket/15173
[ticket/15173] Fix message area resizing lag

* github.com:phpbb/phpbb:
  [ticket/15173] Fix message area resizing lag
Merge pull request #4786 from vinny/ticket/15158
[ticket/15158] Update oauth to v0.8.10

* github.com:phpbb/phpbb:
  [ticket/15158] Update oauth to v0.8.10
[ticket/15151] Use redirected link for consistency
Other phpbb.com links used in the core use a redirect rather than a direct link
so change to make the Cookie settings link a redirect also.

PHPBB3-15151
Merge pull request #4781 from nomind60s/ticket/15151
[ticket/15151] ACP Cookie settings add explanatory text

* github.com:phpbb/phpbb:
  [ticket/15151] Use redirected link for consistency
  [ticket/15151] ACP Cookie settings explanatory text
  [ticket/15151] ACP Cookie settings add explanatory text where it was missing
Merge branch '3.1.x' into 3.2.x
* 3.1.x:
  [ticket/15151] Use redirected link for consistency
  [ticket/15151] ACP Cookie settings explanatory text
  [ticket/15151] ACP Cookie settings add explanatory text where it was missing
Merge pull request #4798 from javiexin/ticket/13735
[ticket/13735] Fix input type number for Firefox in prosilver

* github.com:phpbb/phpbb:
  [ticket/13735] Fix input type number for Firefox in prosilver
Merge branch '3.1.x' into 3.2.x
* 3.1.x:
  [ticket/13735] Fix input type number for Firefox in prosilver
Merge pull request #4763 from javiexin/ticket/15146
[ticket/15146] Date profile field validation incorrect

* github.com:phpbb/phpbb:
  [ticket/15146] Date profile field validation incorrect
Merge branch '3.1.x' into 3.2.x
* 3.1.x:
  [ticket/15146] Date profile field validation incorrect
Merge pull request #4657 from marc1706/ticket/7336
[ticket/7336] Index first post when splitting topics

* github.com:phpbb/phpbb:
  [ticket/7336] Index first post when splitting topics
  [ticket/7336] Add tests for indexing first post after splitting topics
Merge branch '3.1.x' into 3.2.x
* 3.1.x:
  [ticket/7336] Index first post when splitting topics
  [ticket/7336] Add tests for indexing first post after splitting topics
Merge branch '3.1.x' into 3.2.x
* 3.1.x:
  [ticket/13609] Add core.ucp_switch_permissions event
Merge pull request #4669 from senky/ticket/13609
[ticket/13609] Add core.ucp_switch_permissions event

* github.com:phpbb/phpbb:
  [ticket/13609] Add core.ucp_switch_permissions event
Merge branch '3.1.x' into 3.2.x
* 3.1.x:
  [ticket/13608] Add core.ucp_restore_permissions event
Merge pull request #4670 from senky/ticket/13608
[ticket/13608] Add core.ucp_restore_permissions event

* github.com:phpbb/phpbb:
  [ticket/13608] Add core.ucp_restore_permissions event
Merge pull request #4805 from rmcgirr83/ticket-15144
[ticket/15144] Attachment icon display should only occur

* github.com:phpbb/phpbb:
  [ticket/15144] Attachment icon display should only occur
Merge branch '3.2.x' of https://github.com/phpbb/phpbb into ticket/15009
Conflicts:
	phpBB/includes/acp/acp_extensions.php
	phpBB/phpbb/extension/manager.php
@javiexin

This comment has been minimized.

Contributor

javiexin commented Apr 29, 2017

Closed to be replaced by a clean PR.

@javiexin javiexin closed this Apr 29, 2017

@javiexin javiexin deleted the javiexin:ticket/15009 branch Apr 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment