Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/15506] Assign attachrow_template_vars before foreach #5082

Merged
merged 1 commit into from Jan 11, 2018

Conversation

Projects
None yet
5 participants
@marc1706
Copy link
Member

marc1706 commented Jan 11, 2018

The attachrow_template_vars array needs to be defined once in front of the
foreach instead of resetting the array on every iteration of the foreach.

PHPBB3-15506

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-15506

[ticket/15506] Assign attachrow_template_vars before foreach
The attachrow_template_vars array needs to be defined once in front of the
foreach instead of resetting the array on every iteration of the foreach.

PHPBB3-15506

@marc1706 marc1706 added the 3.2 (Rhea) label Jan 11, 2018

@marc1706 marc1706 added this to the 3.2.3 milestone Jan 11, 2018

@canonknipser

This comment has been minimized.

Copy link
Contributor

canonknipser commented Jan 11, 2018

Did a quick test on my testboard, looks fine on preview and edit ;)

@Derky

This comment has been minimized.

Copy link
Member

Derky commented Jan 11, 2018

For me too

@Derky

Derky approved these changes Jan 11, 2018

Derky added a commit to Derky/phpbb that referenced this pull request Jan 11, 2018

Merge pull request phpbb#5082 from marc1706/ticket/15506
[ticket/15506] Assign attachrow_template_vars before foreach

@Derky Derky merged commit 350d4f3 into phpbb:3.2.x Jan 11, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@marc1706 marc1706 deleted the marc1706:ticket/15506 branch Jan 11, 2018

EricTendian added a commit to YSFHQ/phpbb that referenced this pull request Feb 14, 2018

@JulienTant

This comment has been minimized.

Copy link
Contributor

JulienTant commented May 31, 2018

If I decide to apply this on my board, it won't cause any issue with the next update right ?

@luconsta

This comment has been minimized.

Copy link

luconsta commented Aug 29, 2018

Well... just for my curiosity: If the problem was solved from January, how is is possible that I've upgdated now (august 2018) and the problem is still there - I have to "patch" the file manually to solve the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.