Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/15518] Add a setting to toggle permission checks for pms in viewtopic #5094

Merged
merged 1 commit into from Feb 21, 2018

Conversation

@JoshyPHP
Copy link
Contributor

JoshyPHP commented Jan 16, 2018

Disabling permission checks affects the data that is passed core.viewtopic_modify_post_data, namely the can_receive_pm_list and permanently_banned_users vars behave the same they would if no user was disallowed from reading private messages, or banned. This may warrant a note somewhere, although I have been unable to find any extension that relies on those variables.

PHPBB3-15518

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-15518

…iewtopic

PHPBB3-15518
@marc1706 marc1706 changed the base branch from master to 3.2.x Jan 27, 2018
@marc1706 marc1706 closed this Jan 27, 2018
@marc1706 marc1706 reopened this Jan 27, 2018
@marc1706

This comment has been minimized.

Copy link
Member

marc1706 commented Jan 27, 2018

closed and reopened to trigger build against 3.2.x.

@marc1706 marc1706 added the 3.2 (Rhea) label Feb 21, 2018
@marc1706 marc1706 added this to the 3.2.3 milestone Feb 21, 2018
marc1706 added a commit to marc1706/phpbb that referenced this pull request Feb 21, 2018
[ticket/15518] Add a setting to toggle permission checks for pms in viewtopic
@marc1706 marc1706 merged commit f01e29e into phpbb:3.2.x Feb 21, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.