Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/15638] Add word-break for overflowing. #5214

Merged
merged 1 commit into from Jul 8, 2018

Conversation

@ioannisbat
Copy link
Contributor

commented Apr 22, 2018

Checklist:

  • Correct branch: master for new features; 3.2.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.2.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-15638

PHPBB3-15638

@ioannisbat ioannisbat force-pushed the ioannisbat:patch-1 branch 2 times, most recently from 05eeca8 to 2c6cc31 Apr 23, 2018

@ioannisbat ioannisbat changed the title [ticket/15638] Add "word-break" to prevent overflowing [ticket/15638] Add word-break for overflowing. Apr 23, 2018

@ioannisbat ioannisbat force-pushed the ioannisbat:patch-1 branch from 111e031 to 183c1bd Apr 23, 2018

@ioannisbat ioannisbat force-pushed the ioannisbat:patch-1 branch from 183c1bd to 88a23ec Apr 23, 2018

@ioannisbat ioannisbat closed this May 26, 2018

@ioannisbat ioannisbat deleted the ioannisbat:patch-1 branch May 26, 2018

@ioannisbat ioannisbat restored the ioannisbat:patch-1 branch May 26, 2018

@ioannisbat ioannisbat reopened this May 26, 2018

@hanakin

This comment has been minimized.

Copy link
Member

commented May 26, 2018

can you please post before and after screenshots to help with review when making front-end changes

@hanakin hanakin added the Styles 🎨 label May 26, 2018

@ioannisbat

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2018

@hanakin You are right. I just updated it on Tracker. I am just wondering, why is there such a delay in reviews?

@marc1706

This comment has been minimized.

Copy link
Member

commented May 26, 2018

Overall busyness outside phpBB in certainly one of the reasons ;)

@Nicofuma
Copy link
Member

left a comment

thanks for your contribution

@Nicofuma Nicofuma added the 3.2 (Rhea) label Jul 7, 2018

@Nicofuma Nicofuma added this to the 3.2.4 milestone Jul 7, 2018

@Nicofuma Nicofuma merged commit 88a23ec into phpbb:3.2.x Jul 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Nicofuma added a commit that referenced this pull request Jul 8, 2018
Merge pull request #5214 from ioannisbat/patch-1
[ticket/15638] Add word-break for overflowing.

* github.com:/phpbb/phpbb:
  [ticket/15638] Add word-break for overflowing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.