Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/15740] Fix hardcoded Terms/Privacy #5314

Merged
merged 1 commit into from Aug 5, 2018

Conversation

Projects
None yet
3 participants
@Zoddo
Copy link
Contributor

commented Aug 3, 2018

Checklist:

  • Correct branch: master for new features; 3.2.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.2.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-15740

@Zoddo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2018

I made the PR against prep-release-3.2.3 because I think this should be fixed before releasing 3.2.3.

@marc1706

This comment has been minimized.

Copy link
Member

commented Aug 3, 2018

Thanks for the PR. That was also the correct target branch 👍

@marc1706 marc1706 added the 3.2 (Rhea) label Aug 4, 2018

@marc1706 marc1706 added this to the 3.2.3 milestone Aug 4, 2018

marc1706 added a commit to marc1706/phpbb that referenced this pull request Aug 5, 2018

Merge pull request phpbb#5314 from Zoddo/ticket/15740
[ticket/15740] Fix hardcoded Terms/Privacy

@marc1706 marc1706 merged commit c3d664b into phpbb:prep-release-3.2.3 Aug 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.