Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket/15756 Add Lost Username function #5323

Open
wants to merge 6 commits into
base: 3.2.x
from

Conversation

Projects
None yet
5 participants
@v12mike
Copy link
Contributor

commented Aug 15, 2018

Checklist:

  • Correct branch: master for new features; 3.2.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.2.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-15756

v12mike and others added some commits Sep 23, 2017

v12mike
[ticket/15756] Add Lost Username function
This patch adds to the login page and (logged-out) index page a
link 'I forgot my username'.  This link brings up a form for
retrieving username(s) by entering the registered email address.
The response(s) is sent by email, or jabber, as configured for the
user.
For boards that allow multiple accounts per email address, a
username reminder is sent for each account sharing the address.

PHPBB3-15756
v12mike
[ticket/15756] Add Lost Username function
Add (minimal) test case
Fix minor errors in language files

PHPBB3-15756
v12mike
[ticket/15756] Add Lost Username function
Fix minor code format issue

PHPBB3-15756
@v12mike

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

ticket/15756 has been rebased so that it does not include ticket 15726.

Regarding the pull request to 3.2.x rather than master, I consider this functionality to be an extension of the existing 'forgot password' feature, the new code is closely based on that. I hoope that can be the consensus view.

@v12mike

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

I have set up a test board at: https://xantiav6.co.uk/forgotusername/ you can create an account there and try retrieving your forgotten username.

That board is configured to allow email address re-use, so you can verify that case also.

@v12mike v12mike closed this Aug 15, 2018

@v12mike

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

reopened due to (random?) Travis failure

@v12mike v12mike reopened this Aug 15, 2018

@rubencm

This comment has been minimized.

Copy link
Member

commented Aug 15, 2018

Why don't just require email and send user and new password?

@v12mike

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

I think that it is more logical to deal with one item (username or password) at a time and leave it to the user to decide if they need a new password. It would also get a bit ugly in the case where there are multiple usernames per email address.


Somebody (perhaps you) has requested a reminder of the username for your account at "{SITENAME}". Your Username is: {USERNAME}

You can login to "{SITENAME}"at {U_LOGIN}, or use the 'login' link on the forum home page: . Note that the username and password are case-sensitive.

This comment has been minimized.

Copy link
@lavigor

lavigor Aug 15, 2018

Contributor

This line has several issues:

  • no space between site name and at;
  • empty homepage link.

This comment has been minimized.

Copy link
@v12mike

v12mike Aug 16, 2018

Author Contributor

I have pushed a fix.

Note that there is intentionally no homepage link, as the text 'or use the 'login' link on the forum home page.' is an instruction intended for users who prefer not to click links in emails.

v12mike
[ticket/15756] Add Lost Username function
Fixed text in email file

PHPBB3-15756
@Elsensee

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

Wouldn't it be more user-friendly if we just send one email with all usernames instead of spamming the users?
Also.. maybe we need a captcha on that page I guess? (Not sure, though)

@Nicofuma Nicofuma added the 3.2 (Rhea) label Sep 14, 2018

@Nicofuma Nicofuma added this to the 3.2.4 milestone Sep 14, 2018

@Nicofuma

This comment has been minimized.

Copy link
Member

commented Sep 14, 2018

Thanks for your contribution but it should target 3.3 (master). Could you rebase?

@Nicofuma Nicofuma modified the milestones: 3.2.4, 3.3.0-a1 Sep 14, 2018

if ($count == 0)
{
trigger_error('NO_EMAIL_USER');

This comment has been minimized.

Copy link
@Nicofuma

Nicofuma Sep 14, 2018

Member

I wouldn't trigger an error if the email is not used

This comment has been minimized.

Copy link
@v12mike

v12mike Sep 14, 2018

Author Contributor

OK

meta_refresh(3, append_sid("{$phpbb_root_path}index.$phpEx"));
$message = $user->lang(['USERNAME_REMINDER_SENT'], $count) . '<br /><br />' . sprintf($user->lang['RETURN_INDEX'], '<a href="' . append_sid("{$phpbb_root_path}index.$phpEx") . '">', '</a>');

This comment has been minimized.

Copy link
@Nicofuma

Nicofuma Sep 14, 2018

Member

I won't say the number of ent emails either

This comment has been minimized.

Copy link
@v12mike

v12mike Sep 14, 2018

Author Contributor

OK

This comment has been minimized.

Copy link
@v12mike

v12mike Sep 14, 2018

Author Contributor

I will make the suggested changes and rebase to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.