Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/16004] Add check-in for Emojis in Username #5556

Merged
merged 5 commits into from Apr 7, 2019

Conversation

@3D-I
Copy link
Contributor

3D-I commented Mar 31, 2019

PHPBB3-16004

Checklist:

  • Correct branch: master for new features; 3.2.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.2.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-16004

3D-I added 2 commits Mar 31, 2019
PHPBB3-16004
PHPBB3-16004
@VSEphpbb

This comment has been minimized.

Copy link
Member

VSEphpbb commented Mar 31, 2019

Should test this in the validate_username_test test

PHPBB3-16004
@3D-I

This comment has been minimized.

Copy link
Contributor Author

3D-I commented Mar 31, 2019

I will see to add such test therein.

@3D-I 3D-I closed this Mar 31, 2019
@3D-I 3D-I reopened this Mar 31, 2019
@3D-I 3D-I closed this Mar 31, 2019
@3D-I 3D-I reopened this Mar 31, 2019
@VSEphpbb

This comment has been minimized.

Copy link
Member

VSEphpbb commented Mar 31, 2019

Also, just a thought... Is it true Emoji are not allowed in a name? Why not?

Edit: nevermind... Looks like phpBB explodes if you try to register with emoji in your name.

@DavidIQ

This comment has been minimized.

Copy link
Member

DavidIQ commented Mar 31, 2019

Well I think I'd rather support them than deny them. But perhaps that's something that we need to push off for a future version as it would require the username column data type to be changed, a likely expensive and time-consuming operation.

@VSEphpbb

This comment has been minimized.

Copy link
Member

VSEphpbb commented Mar 31, 2019

But it would be kind of hard to know what to call a user named: 🐸

@DavidIQ

This comment has been minimized.

Copy link
Member

DavidIQ commented Mar 31, 2019

"Kermit"? "None of my business meme"? "Pepe"? "Frogger"? Take your pick 😆

@3D-I

This comment has been minimized.

Copy link
Contributor Author

3D-I commented Apr 1, 2019

If you allow emojis in usernames then many other tables will break, like Logs, Notifications etc.

@3D-I

This comment has been minimized.

Copy link
Contributor Author

3D-I commented Apr 1, 2019

The test is a courtesy of @mrgoldy 👍

@3D-I 3D-I closed this Apr 1, 2019
@3D-I 3D-I reopened this Apr 1, 2019
@marc1706 marc1706 added the 3.2 (Rhea) label Apr 7, 2019
@marc1706 marc1706 added this to the 3.2.6 milestone Apr 7, 2019
marc1706 added a commit to marc1706/phpbb that referenced this pull request Apr 7, 2019
[ticket/16004] Add check-in for Emojis in Username
@marc1706 marc1706 merged commit 7160c67 into phpbb:3.2.x Apr 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@3D-I 3D-I deleted the 3D-I:ticket/16004 branch Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.