[ticket/PHPBB3-10661] Added missing   to BBC group template in posting editor #658

Closed
wants to merge 128 commits into
from

Conversation

Projects
None yet
5 participants
@NeoAdonis
Contributor

NeoAdonis commented Mar 24, 2012

The posting_editor template in prosilver style now has a   added in the bbc_recpipient.IS_GROUP part, as in the to_recipient.IS_GROUP part.

PHPBB3-10661

callumacrae added some commits Jul 14, 2011

[ticket/10270] Added JavaScript popups and basic AJAX functionality t…
…o PHP.

This commit adds the phpbb object (JavaScript), and alert and confirm box
methods. It also adds the first basic AJAX functionality, to deleting posts
in viewtopic.

PHPBB3-10270
[ticket/10271] Added phpbb.confirm_box (JavaScript).
As well as adding the method, this commit also changes the previous commit
so that deleting a post from viewtopic uses this method, too. This commit
has also made some improvements to phpbb.alert and phpbb.confirm.

PHPBB3-10271
[ticket/10272] AJAXified most links.
This commit makes some significant changes to the phpbb.confirm_box function
(namely, removing some duplicate code), and also manually adds most link
to the phpBB AJAX functions.

PHPBB3-10272
[feature/ajax] Cleaned up AJAX-related JavaScript.
Mostly just added comments, but has cleaned up some actual code too.
[ticket/10273] AJAXified approve / disapprove posts (in viewtopic).
This commit AJAXifies the moderator approval functionality, and adds it to
viewtopic instead of the MCP. This commit has involved some language changes,
which may affect fallbacks.

PHPBB3-10273
[ticket/10270] Cleaned up code and made popups fade.
This commit cleans up some code - mostly, replacing all instances of __self
with "that", and also replacing the parse_hidden function with jQuerys built
in .serialize. It also adds animations to the popups.

PHPBB3-10270
[ticket/10273] Added phpbb.ajaxify_form and converted accept / deny t…
…o it.

Also made a few minor improvements to other JavaScript.

PHPBB3-10273
[feature/ajax] Reduced duplicate code by merging all AJAX function in…
…to one.

This commit merges phpbb.confirm_box, phpbb.ajaxify and phpbb.ajaxify_form into
one function which automatically detects what is happening and calls the
correct code accordingly. This has removed a lot of duplicate code and
generally made the code cleaner.
[ticket/10270] Changed function names of jQuery modifications.
The code was modifying the jQuery code before, now the functions have been
renamed to unused function names.

PHPBB3-10270
[ticket/10272] Made some jQuery selectors more specific to avoid conf…
…licts.

Before, a link to any URL with, say, "mode=bump" in the title would have been
prevented from acting normally.

PHPBB3-10272
[ticket/10271] Added ability for exceptions to phpbb.ajaxify.
Also made it easy for additional options to be added in the future.

PHPBB3-10271
[ticket/10270] Removed the js anim functions.
This commit removes the hide_anim, show_anim and remove_anim functions and
replaces them with built in jQuery function that do exactly the same thing.

PHPBB3-10270
[feature/ajax] Replaced jQuery selectors with data attributes.
Due to problems that could have been caused by selecting the element using
jQuery selectors, they have been replaced by HTML5 data attributes.
[ticket/10271] AJAXified Quick-mod tools.
Also made some improvements to the exceptions.

PHPBB3-10271
[ticket/10291] AJAXified quick reply form.
Also changed the show quick reply button to a button, not a submit - it was
affecting the behaviour of phpbb.ajaxify.

PHPBB3-10291
[ticket/10270] Fixed a bug where fadedark wouldn't go.
If the confirm box was submitted as yes, then the fadedark would stay until it
was clicked. This commit fixes that.

PHPBB3-10270
[feature/ajax] Fixed a small bug in the JavaScript.
The bug meant that code outside of the function that ran on document ready would
not be able to access the phpbb object.
[ticket/10328] Added a JSON class.
The JSON class adds a consistent way to send JSON to the client, making
it perfect for AJAX (jQuery automatically parses it).

PHPBB3-10328
[ticket/10270] Lengthened the timeout on the AJAX request error.
It was at 3 seconds before, now it is at 5 seconds from when the popup
has faded in.

PHPBB3-10270
[ticket/10272] Zebra operations using AJAX are now less hacky.
Before, they were splitting stuff by the <br />, and now JSON::add() is
being used.

PHPBB3-10272
[ticket/10270] Added jQuery popup CSS to the ACP.
It was missing previously, meaning that it displayed wrong and in the
footer.

PHPBB3-10270
[ticket/10328] Renamed the JSON class, also now using autoloading.
It is no longer static, and uses autoloading. It has also been renamed
from JSON to phpbb_json_response.

PHPBB3-10328
[ticket/10271] AJAXified various deletions in the ACP.
The following places have had deletion AJAXified:
* Smilies and icons
* Word censors
* BBCodes
* Attachment groups
* Groups
* Admin / User / Moderator / Forum roles
* Report / denial reasons
* Module management
* Custom profile fields

PHPBB3-10271
[ticket/10271] Cleaned up phpbb.ajaxify.
Reduced a lot of duplicate code and made it more efficient.

PHPBB3-10271

igorw and others added some commits Feb 8, 2012

Merge branch 'develop' into feature/ajax
* develop:
  [ticket/10634] Specify module type when viewing profile
  [ticket/10634] Changing p_master::is_full_class
[feature/ajax] Better handling for zebra
Better handling for zebra: message is displayed instead of first .zebra. Other .zebra entries are emptied, but not completely removed to avoid changing layout.

PHPBB3-10272
Merge remote-tracking branch 'cyberalien/feature/ajax-commits/zebra' …
…into feature/ajax

* cyberalien/feature/ajax-commits/zebra:
  [feature/ajax] Better handling for zebra
Merge branch 'develop' into feature/ajax
* develop:
  [ticket/10641] Update MCP template with new plurality forms
  [ticket/10637] Leftovers from implementation of extensions in convertor
  [ticket/10637] Leftovers from implementation of extensions in develop tools
  [ticket/10637] Leftovers from implementation of extensions in mcp_post
  [ticket/10637] Leftovers from implementation of extensions in mcp_main
  [ticket/10637] Leftovers from implementation of extensions
  [ticket/10606] Also correctly use $s_search_hidden_fields in view(forum|topic).
  [ticket/10606] Fix incorrect hidden fields array name in page_header().
  [ticket/10633] Stop leaking filename of attachments when thumbnail is requested
  [ticket/10636] Resolve variable name ($sql_ary) conflict in cache_moderators().
  [ticket/10569] Invalid string comparison in prosilver
  [ticket/10495] Update request/type_cast_helper for PHP 5.4 magic_quotes_gpc drop
  [ticket/10512] Call startup.php from tests/bootstrap.php
  [ticket/10569] Invalid string comparison in subsilver2
  [ticket/10076] STARTTLS support for SMTP via smtp_class.
  [ticket/10076] Move EHLO/HELO code into its own method.
[ticket/10291] Fixed a bug in the quick reply AJAX.
It wasn't submitting, as jQuery was ignoring the submit value.

PHPBB3-10291
Merge pull request #9 from callumacrae/feature/ajax
[ticket/10291] Fixed a bug; when qr form submitted, it wouldn't fade out...
[ticket/10270] Disabling links in disappearing content
Disabling click events for blocks that are being removed via ajax

PHPBB3-10270
[ticket/10270] Changing close button for ajax popups
Changed close button for popups to match prosilver style and from img to css, moved color values to colours.css

PHPBB3-10270
Merge pull request #11 from cyberalien/feature/ajax
Changing close button for popups
[ticket/PHPBB3-10661] Added missing &nbsp; to BBC group template in p…
…osting editor

The posting_editor template in prosilver style now has a &nbsp; added in the bbc_recpipient.IS_GROUP
part, as in the to_recipient.IS_GROUP part.

PHPBB3-10661
@imkingdavid

This comment has been minimized.

Show comment Hide comment
@imkingdavid

imkingdavid Mar 24, 2012

Contributor

Looks fine to me.

Contributor

imkingdavid commented Mar 24, 2012

Looks fine to me.

@callumacrae

This comment has been minimized.

Show comment Hide comment
@callumacrae

callumacrae Mar 26, 2012

Member

Your commit message needs fixing. The first line should start [ticket/10661], not [ticket/PHPBB3-10661]. Every line should be a maximum of 79 lines wide, so that also needs fixing.

You can change a commit message using git commit --amend.

Code looks good, though.

Member

callumacrae commented Mar 26, 2012

Your commit message needs fixing. The first line should start [ticket/10661], not [ticket/PHPBB3-10661]. Every line should be a maximum of 79 lines wide, so that also needs fixing.

You can change a commit message using git commit --amend.

Code looks good, though.

@imkingdavid

This comment has been minimized.

Show comment Hide comment
@imkingdavid

imkingdavid Mar 30, 2012

Contributor

@NeoAdonis In addition to what @callumacrae said, your commit message also incorrectly says BBC, where it should say BCC. The code itself is bcc, so that's fine.

Contributor

imkingdavid commented Mar 30, 2012

@NeoAdonis In addition to what @callumacrae said, your commit message also incorrectly says BBC, where it should say BCC. The code itself is bcc, so that's fine.

@NeoAdonis

This comment has been minimized.

Show comment Hide comment
@NeoAdonis

NeoAdonis Apr 4, 2012

Contributor

Something went wrong during the amend, so I think I'll close this and I'll create another pull request. Sorry.

Contributor

NeoAdonis commented Apr 4, 2012

Something went wrong during the amend, so I think I'll close this and I'll create another pull request. Sorry.

@NeoAdonis NeoAdonis closed this Apr 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment