[ticket/10727] Do not hide Quick Reply with javascript on prosilver #660

Merged
merged 1 commit into from Mar 30, 2012

Conversation

Projects
None yet
5 participants
Contributor

imkingdavid commented Mar 25, 2012

Note that this pull request is probably not compatible with phpbb#659 (and vice versa) because they both change the same file in different ways, so whichever isn't merged first will have to be redone, right?

Member

callumacrae commented Mar 26, 2012

Yeah, but it'll be easy enough to resolve.

Member

VSEphpbb commented Mar 26, 2012

With this change, do we still need the "Post Reply" button that appears under the Quick Reply anymore when QR is enabled? Seems very redundant, since the "Full Editor" - soon to become - "Preview" button will take you to the same place as the Post Reply button does.

Submit, Preview, Post Reply....so many buttons... what does it all mean!

Member

callumacrae commented Mar 26, 2012

Yes, it'll still be required. It'd be too confusing to remove it.

Contributor

imkingdavid commented Mar 26, 2012

Yes, the post reply button should stay even when the QR is enabled.

Member

VSEphpbb commented Mar 26, 2012

Well then there may be some more work to do here. Because it might also be confusing as it stands to end-users:

Having the standard "Post Reply" button under the QR area (as it is now) means some users may hit that after writing their post. That would then take them to a blank full editor, and everything they just wrote in the QR box will be gone.

It should to have the awareness to carry any possible text in the QR box over to the Full Posting page (as the Full Editor button would do). It could use some fool-proofing ;)

Contributor

imkingdavid commented Mar 26, 2012

This is not an issue currently with the Quick Reply so I do not see why it would be an issue after this patch is merged. The buttons on the QR are styled differently than the image button that is also at the top of the screen. I think most users know enough to realize that the two buttons do two different thing.

But thanks for pointing this out. I will consider it, but at the moment I'm not sure it's really necessary to do all that.

Contributor

cyberalien commented Mar 29, 2012

I agree with VSEphpbb about redundant buttons. Maybe hide default "reply" button when quick reply is enabled, so users would click "full editor" to show full editor instead?

Contributor

imkingdavid commented Mar 29, 2012

Currently, both the Full Editor button and the Post Reply link go to the full editor, with the only difference being the fact that the Full Editor button carries over the QR text. As far as I know, there is currently no confusion when someone clicks to enable the QR block about which button to use. Why would confusion arise then if the block is shown instead of hidden?

Anyway, I suppose this isn't a big deal, and if I have to do this I will, but I just don't see how users would be any more confused than they currently are. If they currently are confused, I haven't heard anything about it but I suppose that would be something to consider in relation to this.

Member

callumacrae commented Mar 29, 2012

I've never heard of anyone being confused about this.

Currently, both the Full Editor button and the Post Reply link go to the full editor, with the only difference being the fact that the Full Editor button carries over the QR text. As far as I know, there is currently no confusion when someone clicks to enable the QR block about which button to use. Why would confusion arise then if the block is shown instead of hidden?

Anyway, I suppose this isn't a big deal, and if I have to do this I will, but I just don't see how users would be any more confused than they currently are. If they currently are confused, I haven't heard anything about it but I suppose that would be something to consider in relation to this.


Reply to this email directly or view it on GitHub:
phpbb#660 (comment)

Member

VSEphpbb commented Mar 29, 2012

@imkingdavid I'm just thinking of making the UI fool proof for all forum users. Think of the little housewife making her first post ever on a forum, from her kitchen computer - we should strive to make things as intuitive and easy for her as they are for us. :)

Contributor

cyberalien commented Mar 29, 2012

Those buttons are next to each other, they have different text. User new to forums could think that they perform different functions.

Member

VSEphpbb commented Mar 30, 2012

Isn't it just as simple as changing:

into

at the bottom of viewtopic_body.html ?

Well, it's just something to consider.

Contributor

imkingdavid commented Mar 30, 2012

Yes, that is pretty much the extent of the change that is needed. But keep in mind that subSilver2 does not hide the QR box and it shows both reply options, and there is no issue there. Anyway, yeah, I'll consider it.

Contributor

cyberalien commented Mar 30, 2012

Maybe merge as it is, enable quick reply on area51 forums and listen to feedback from users? Hiding "post reply" button is easy and can be done later.

Contributor

igorw commented Mar 30, 2012

👍

@cyberalien cyberalien merged commit cfb8f01 into phpbb:develop Mar 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment