Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/10819] Improve side-by-side diff styling #755

Merged
merged 3 commits into from May 5, 2012

Conversation

@Noxwizard
Copy link
Member

commented Apr 16, 2012

Used transparent background for unchanged lines
Shortened the table headers and make the background grey
Added a border between the columns
Increased the font size on pre blocks
Added Consolas as the first pre font, for Windows users
Added wordwrapping for pre blocks

PHPBB3-10819

Noxwizard added 2 commits Apr 16, 2012
[ticket/10819] Improve side-by-side diff styling
Used transparent background for unchanged lines
Shortened the table headers and make the background grey
Added a border between the columns
Increased the font size on pre blocks
Added Consolas as the first pre font, for Windows users
Added wordwrapping for pre blocks

PHPBB3-10819
white-space: pre-wrap; /* css-3 */
white-space: -moz-pre-wrap !important; /* Mozilla, since 1999 */
white-space: -pre-wrap; /* Opera 4-6 */
white-space: -o-pre-wrap; /* Opera 7 */

This comment has been minimized.

Copy link
@cyberalien

cyberalien Apr 16, 2012

Contributor

All 3 prefixed versions are not needed, FF3+ supports pre-wrap without prefix, so does Opera

This comment has been minimized.

Copy link
@Noxwizard

Noxwizard Apr 17, 2012

Author Member

@cyberalien We don't specify anywhere what browsers and versions we support. What are you proposing the cutoff point be?

This comment has been minimized.

Copy link
@cyberalien

cyberalien Apr 17, 2012

Contributor

Those browsers aren't used at all, so its not an issue.

This comment has been minimized.

Copy link
@nickvergessen

nickvergessen Apr 20, 2012

Contributor

I kind of agree with @Noxwizard here. Maybe we should summarize somewhere which browsers we want to support fully and list on others which features/stylings are missing.

@cyberalien

This comment has been minimized.

Copy link
Contributor

commented May 1, 2012

Looks good. However I can't test with IE.

@bantu bantu merged commit 00c54f8 into phpbb:develop-olympus May 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.