[ticket/10778] Remove extra space in link Close Window from prosilver/template/posting_smilies.html #774

Merged
merged 1 commit into from May 1, 2012

Projects

None yet

3 participants

@vinny
Member
vinny commented Apr 24, 2012
@callumacrae
Member

Your commit message should be:

[ticket/10778] Fix Close Window link - posting_smilies.html on prosilver

PHPBB3-10778

You can change it using git commit --amend, no need to open a new PR.

@vinny
Member
vinny commented Apr 27, 2012

@callumacrae,

Fixed. ;D

@bantu
Member
bantu commented Apr 28, 2012

This commit does not "Fix Close Window Link" as the "close window" link is just working fine.

@bantu
Member
bantu commented May 1, 2012

Commit message lines should be 80 chars max. See http://wiki.phpbb.com/Git#Commit_Messages

@bantu
Member
bantu commented May 1, 2012

How about this:
string(78) "[ticket/10778] Remove extra space from close link in prosilver smilies window."

@vinny
Member
vinny commented May 1, 2012

Done.

Thanks bantu. :D

@bantu bantu merged commit 7294c71 into phpbb:develop May 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment