Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[ticket/10778] Remove extra space in link Close Window from prosilver/template/posting_smilies.html #774

Merged
merged 1 commit into from

3 participants

@callumacrae

Your commit message should be:

[ticket/10778] Fix Close Window link - posting_smilies.html on prosilver

PHPBB3-10778

You can change it using git commit --amend, no need to open a new PR.

@vinny

@callumacrae,

Fixed. ;D

@bantu
Owner

This commit does not "Fix Close Window Link" as the "close window" link is just working fine.

@bantu
Owner

Commit message lines should be 80 chars max. See http://wiki.phpbb.com/Git#Commit_Messages

@bantu
Owner

How about this:
string(78) "[ticket/10778] Remove extra space from close link in prosilver smilies window."

@vinny

Done.

Thanks bantu. :D

@bantu bantu merged commit 7294c71 into phpbb:develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 1, 2012
  1. @vinny
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  phpBB/styles/prosilver/template/posting_smilies.html
View
2  phpBB/styles/prosilver/template/posting_smilies.html
@@ -18,6 +18,6 @@
</div>
</div>
<div>{PAGINATION}</div>
-<a href="#" onclick="window.close(); return false;">{L_CLOSE_WINDOW}</a>
+<a href="#" onclick="window.close(); return false;">{L_CLOSE_WINDOW}</a>
<!-- INCLUDE simple_footer.html -->
Something went wrong with that request. Please try again.