Gravatar #8
Gravatar #8
Conversation
* commit 'release-3.0.8': (393 commits) [prep-release-3.0.8] Incrementing version number to 3.0.8 and update changelog [ticket/9903] Script for detecting potentially malicious flash bbcodes [ticket/9904] Update WebPI Parameters.xml to work with WebMatrix. [ticket/9899] Change recaptcha theme from default to 'clean' in the ACP. [ticket/9509] Fix a typo and wrong period placement [ticket/9903] Fix XSS in BBcode-parser's Flash-BBcode. [develop-olympus] Updating changelog for last minute 3.0.8-RC1 fixes. [ticket/9140] Check current board version in incremental update packages [ticket/9891] Updater drops language-selection after database-update [develop-olympus] Updating changelog with latest changes for 3.0.8-RC1 [ticket/9884] Reduce queue interval to 60 seconds, email package size to 20 [ticket/9886] Update fails on PostgreSQL because of an error in _add_module [ticket/9888] Update fails when Bing [Bot] was already added to the users table [develop-olympus] Bumping version number for 3.0.8-RC1. [ticket/9885] Fix extension group name updater. Loop through all languages. [ticket/9847] Fix typo in search synonyms. Use british english for 'judgement'. [ticket/9883] Change an American English spelling to British English. [task/phing-build] Correct the path for update package patch files. [ticket/9880] Change "antibot" to "anti-spambot". [ticket/9696] Surpress is_dir() notice when using SQLite with open_basedir. ...
Going to do some testing then add some more features to it, such as allowing the board admin to specify the rating and defautlt image.
Everything seem to work.
|
From quickly skimming over it, you're not following the coding guidelines everywhere with your ifs. 'usegravatar' could maybe be 'use_gravatar'. The modules table needs to be adjusted to reflect the new avatar display conditions in the UCP. There should be a ticket for this, the branch should be named 'feature/gravatar' and the commit messages should follow the guidelines described here. The commits could perhaps be squashed and rebased to make things a little cleaner. Apart from that, it looks pretty good so far. Thumbs up. I think we should include this in ascraeus, also considering how small the patch is. Oh, and my bad, just saw that there actually is a ticket. :) |
|
This feature needs to come with tests in order to be merged. Ideally we would refactor the code so that adding more avatar types will not require extensive code changes anymoe. |
|
I'll make the requested changes on another branch (feature/gravatar) and consolidate the changes to a single commit. There is also a really picky, consistency thing with a config var I named I would like to fix anyway. As far as testing goes, I will look into it and resubmit the pull request with proper tests. |
Created a new avatar type allowing users to use their Gravatar associated with their email address. Addtional ACP controls have been added to allow the admin to specify a max content rating, default image, and default Gravatar size. PHPBB3-9498
| @@ -2259,6 +2297,13 @@ function avatar_get_dimensions($avatar, $avatar_type, &$error, $current_x = 0, $ | |||
| case AVATAR_REMOTE : | |||
| break; | |||
|
|
|||
| case AVATAR_GRAVATAR : | |||
| // Note: we actually return in this case. We accecpt whatever | |||
|
Cullen has been working on a proper implementation of avatar abstraction so I'll close this pull request. |
| { | ||
| global $user, $config; | ||
|
|
||
| // Hieght and width, Gravatars are /always/ square, and we are using 80 is |
There was a problem hiding this comment.
Hieght -> Height
you also might not want to capitalise it
|
This pull request has already been closed in favour of a more generalized implementation. |
|
I noticed that after I commented on it. |
Feature/events
Benutze before_script Sektion für Programminstallation.
[ticket/security-169] Stop loop through referer dir in top directory
Add message about htaccess when installing/updating
[ticket/16935] Add sphinx tests
http://tracker.phpbb.com/browse/PHPBB3-9498
Adds the following: