Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adds the following:
From quickly skimming over it, you're not following the coding guidelines everywhere with your ifs. 'usegravatar' could maybe be 'use_gravatar'. The modules table needs to be adjusted to reflect the new avatar display conditions in the UCP.
There should be a ticket for this, the branch should be named 'feature/gravatar' and the commit messages should follow the guidelines described here. The commits could perhaps be squashed and rebased to make things a little cleaner.
Apart from that, it looks pretty good so far. Thumbs up. I think we should include this in ascraeus, also considering how small the patch is.
Oh, and my bad, just saw that there actually is a ticket. :)
I'll make the requested changes on another branch (feature/gravatar) and consolidate the changes to a single commit. There is also a really picky, consistency thing with a config var I named I would like to fix anyway.
As far as testing goes, I will look into it and resubmit the pull request with proper tests.