Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11025] Make last topic titles in forum list Bold #924

Merged
merged 4 commits into from Jul 24, 2012

Conversation

@VSEphpbb
Copy link
Member

commented Jul 24, 2012

This small style tweak will make the truncated last topic titles
shown in the forum list BOLD for better visual impact.
http://tracker.phpbb.com/browse/PHPBB3-11025

PHPBB3-11025

[ticket/11025] Make last topic titles in forum list Bold
This small style tweak will make the truncated last topic titles
shown in the forum list BOLD for better visual impact.

PHPBB3-11025
@naderman

This comment has been minimized.

Copy link
Member

commented Jul 24, 2012

Think we should use the semantic <strong> rather than <b>. Or better yet just assign a class to it and add a CSS rule, so the theme can decide this.

@travisbot

This comment has been minimized.

Copy link

commented Jul 24, 2012

This pull request passes (merged eeb7b1b into efbc02a).

@vinny

This comment has been minimized.

Copy link
Member

commented Jul 24, 2012

I think <strong> is better.

@VSEphpbb

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2012

@naderman
@MVinny
I tried strong, but it did not work. Apparently there is some kind of styling on strong when used in this location that resulted in doing nothing more than turning the text black (and not weighting it bold).

Spread throughout the css there is an li.row strong class defining color as black and font-weight as normal.

@naderman

This comment has been minimized.

Copy link
Member

commented Jul 24, 2012

@VSEphpbb Then I would prefer you just assign this a class, e.g. post-subject and make it font-weight:bold.

@travisbot

This comment has been minimized.

Copy link

commented Jul 24, 2012

This pull request passes (merged 8c337a2 into efbc02a).

@naderman

This comment has been minimized.

Copy link
Member

commented Jul 24, 2012

Should probably also have an underline rule for hover, no?

@travisbot

This comment has been minimized.

Copy link

commented Jul 24, 2012

This pull request fails (merged 4ff6448 into efbc02a).

naderman added a commit that referenced this pull request Jul 24, 2012
Merge pull request #924 from VSEphpbb/ticket/11025
[ticket/11025] Make last topic titles in forum list Bold

@naderman naderman merged commit d1e5686 into phpbb:develop Jul 24, 2012

@naderman

This comment has been minimized.

Copy link
Member

commented Jul 24, 2012

Great, thanks! Merged.

@travisbot

This comment has been minimized.

Copy link

commented Jul 24, 2012

This pull request passes (merged edec4a4 into efbc02a).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.