Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[task/10869] Remove PHP 5.2 check from .travis.yml #791

Merged
merged 1 commit into from
May 3, 2012

Conversation

erikfrerejean
Copy link

The travis configuration file contains a statement that checks whether
the test is ran against PHP 5.2 but as that version isn't tested at
all the check can be removed.

http://tracker.phpbb.com/browse/PHPBB3-10869

PHPBB3-10869

@travisbot
Copy link

This pull request fails (merged 0e906f2 into 7426c7a).

@bantu
Copy link
Collaborator

bantu commented May 3, 2012

This line also exists in develop-olympus. I don't think changing it makes sense.

The travis configuration file contains a statement that checks whether
the test is ran against PHP 5.2 but as that version isn't tested at
all the check can be removed.

PHPBB3-10869
@erikfrerejean
Copy link
Author

Well obviously it does as develop-olympus gets tested agains 5.2, kinda useless to check for something that is impossible to become true.

@naderman
Copy link
Sponsor Member

naderman commented May 3, 2012

True, but also kind of pointless, so whatever.

naderman added a commit that referenced this pull request May 3, 2012
[task/10869] Remove PHP 5.2 check from .travis.yml
@naderman naderman merged commit 859c3ca into phpbb:develop May 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants