Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not do realpath as this breaks the error message #112

Merged
merged 1 commit into from May 21, 2014

Conversation

dantleech
Copy link
Member

realpath returns an empty string if the path does not exist, better to simply not use it ..

@@ -83,7 +83,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
foreach ($filePaths as $filePath) {
$cnd = file_get_contents($filePath);
$this->updateFromCnd($output, $session, $cnd, $allowUpdate);
$output->writeln(sprintf('Registered: <info>%s</info>', $filePath));
$output->writeln(sprintf('Registered node type: <info>%s</info>', $filePath));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would that not be: "Registered node types and namespaces from %s" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i guess, what about Node type definition registered: ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is fine too. maybe "Node type definition registered from: "? your call.

$count++;
}

$output->writeln(sprintf('%d node definition file(s)', $count));
$output->writeln(sprintf('%d node definition(s) registered', $count));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to simply "Node type definition: %s" and then the summary is already "%d node definition(s) registered". Trying to be as concise as possible.

dbu added a commit that referenced this pull request May 21, 2014
Do not do realpath as this breaks the error message
@dbu dbu merged commit 60dc21b into master May 21, 2014
@dbu dbu deleted the fixed_node_type_register branch May 21, 2014 06:32
@dbu
Copy link
Member

dbu commented May 21, 2014

like it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants