Dot not escaped in path eval in Sql2Generator.php #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found this broken for my node path which was something like /mypath/pages/23948327.3489 Im sure this fixes my problem. But its probably better to check for non-alpha-numeric characters using a regex. If so just escape it, i guess it cant hurt that much. But I leave that for the SQL2 gurus since this is my first real encounter with SQL2
Author
|
Any chance this can be merged? |
lsmith77
added a commit
that referenced
this pull request
Dec 14, 2012
Dot not escaped in path eval in Sql2Generator.php
Member
|
@dbu who ever gets to this first should check if we need to look for non alpha num chars |
Member
|
hm, why not always quote if its not already quoted? does it do any harm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this broken for my node path which was something like
/mypath/pages/23948327.3489
Im sure this fixes my problem. But I think its probably better to check for non-alpha-numeric characters using a regex. But I leave that for the SQL2 gurus since this is my first real encounter with SQL2