Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

JSR-333 updates #52

Merged
merged 14 commits into from Jan 12, 2013

Conversation

Projects
None yet
2 participants
Owner

dbu commented Nov 28, 2012

Once this is merged, also update http://java.net/jira/browse/JSR_333-59

Done

  • Item::revert instead of Item::refresh
  • LockInfo timeOutHint versus timeoutHint
  • unregisterNamespace => unregisterNamespaceByURI
  • NodeInterface
    • getNodeNames
    • getPropertyWithDefault
    • setMixins
    • rename
    • addNodeAutoNamed
    • covered by getPropertyValue($name, $type)
      • getPropertyAs
      • getPropertyAsString
      • getPropertyAsStringArray
  • RepositoryManagerInterface (new interface)
  • SessionInterface
    • getNode(absPath, depthHint)
    • getProperties
  • WorkspaceInterface
    • removeItem
  • NodeTypeInterface
    • getSupertypeNames
  • EventFilter (new interface)
  • ObservatiomManager
    • - addEventLister(eventTypes, absPath, etc...)
    • - getEventJournal(eventTypes, absPath, etc...)
    • + addEventLister(EventFilter)
    • + getEventJournal(EventFilter)
Owner

dbu commented Dec 3, 2012

this PR is now ready. some careful review would be appreciated.

Owner

dbu commented Jan 7, 2013

@lsmith77 think we can merge this as well?

/cc @bergie this will impact on the phpcr midgard bindings as well - the changes are fairly minor though, as you probably don't support events and such things. mainly some new syntactic sugar methods.

Owner

dbu commented Jan 12, 2013

@lsmith77 should we merge this before our release tagging round? i would suggest so. there is mainly cleanup on sections we did not yet implement and some new convenience and optimization methods that have no BC break.

Owner

lsmith77 commented Jan 12, 2013

yeah lets merge ..

lsmith77 added a commit that referenced this pull request Jan 12, 2013

@lsmith77 lsmith77 merged commit 7fd5665 into master Jan 12, 2013

1 check passed

default The Travis build passed
Details
Owner

lsmith77 commented Jan 12, 2013

i have reverted the merge .. it seems like we need to need to merge this PR, create a tag and merge the jackalope PR more or less at the same time

@dbu dbu deleted the jsr-333 branch Jan 13, 2013

Owner

dbu commented Jan 13, 2013

@lsmith77 you did undo the undo now, right? so jsr-333 is indeed now fully merged?

Owner

lsmith77 commented Jan 13, 2013

yes i did .. its all merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment