Use ConstantTimeMath for Signer #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n suitable for handling private keys. Fixes phpecc#279. To use this algorithm, pass the `ConstantTimeMath` object to the `Signer` or `Random` constructor. (Easy-ECC will do this automatically for users when constant-time arithmetic is needed.)
Remove unnecessary import.
The reference implementation in sodium_compat assumes little-endian byte order. GMP assumes big-endian.
paragonie-security
force-pushed
the
ct-signer
branch
9 times, most recently
from
198a4cc
to
e4fc710
Compare
paragonie-security
force-pushed
the
ct-signer
branch
from
e4fc710
to
a2ef137
Compare
|
Feel free to reject this one if you want to approach this differently,@afk11. |
paragonie-security
added a commit
to paragonie/easy-ecc
that referenced
this pull request
Jun 2, 2022
This is mostly because phpecc/phpecc#280 and phpecc/phpecc#281 aren't merged. See discussion in phpecc/phpecc#279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #280, but uses ConstantTimeMath for Signer.
a2ef137