Skip to content

Minor fixes to help.php #12

Merged
merged 3 commits into from May 8, 2012

2 participants

@MarkMaldaba

These 3 commits fix a number of PHP notice-level errors that were being generated in help.php.

MarkMaldaba added some commits Apr 28, 2012
@MarkMaldaba MarkMaldaba Fixed notice-level PHP error in help.php: Notice: Undefined variable:…
… f in ~\help.php on line 19

This was due to an incorrect variable name being used (copy/paste error).

Issue logged, with patch file, at ProjectPier site: http://www.projectpier.org/node/3243
3206c9f
@MarkMaldaba MarkMaldaba Fixed another notice-level PHP error in help.php: Notice: Undefined v…
…ariable: d in ~\help.php on line 33

This was due to an incorrect variable name being used (copy/paste error).

Patch file added to existing issue at ProjectPier site: http://www.projectpier.org/node/3243
b7dca9d
@MarkMaldaba MarkMaldaba In the check_directory() and check_file() functions in help.php, ther…
…e are a bunch of checks that will fail with a PHP notice if the file/directory doesn't exist. Also, checks such as whether the file is readable are a bit meaningless for non-existent items.

This commit updates the functions so that they bail out after the first test if the item does not exist. This avoids the PHP errors and meaningless information that is otherwise displayed.

Logged as an issue at ProjectPier, with patch file attached: http://www.projectpier.org/node/3244
107cd39
@phpfreak phpfreak merged commit 1432228 into phpfreak:master May 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.