Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ext-xml to require in composer.json file #429

Merged
merged 2 commits into from Dec 21, 2016

Conversation

WhiteEagle88
Copy link

No description provided.

@ravage84
Copy link
Member

Which part of the PHPMD uses this?

The JSON does not look valid, by the way...

@ravage84 ravage84 added this to the 2.5.1 milestone Dec 20, 2016
@WhiteEagle88
Copy link
Author

@ravage84
"Which part of the PHPMD uses this?":

"The JSON does not look valid, by the way...": What do you mean?

@@ -36,7 +36,8 @@
"minimum-stability" : "stable",
"require": {
"php": ">=5.3.9",
"pdepend/pdepend": "^2.2"
"pdepend/pdepend": "^2.2",
"ext-xml": *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://getcomposer.org/doc/04-schema.md#package-links

"ext-xml": "*"

With double quotes.

@ravage84
Copy link
Member

Thanks for pointing that out. I'll merge it, once the JSON is fixed.

@WhiteEagle88
Copy link
Author

Oh, sorry. I fixed, thanks.

@ravage84 ravage84 merged commit db49f20 into phpmd:master Dec 21, 2016
@ravage84
Copy link
Member

Thanks!

@ravage84 ravage84 modified the milestones: 2.5.1, 2.6.0 Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants