Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PHP 7.4 #257

Merged
merged 2 commits into from Dec 20, 2019
Merged

Update to PHP 7.4 #257

merged 2 commits into from Dec 20, 2019

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Nov 29, 2019

No description provided.

@williamdes
Copy link
Member

@J0WI can you do the upgrade to 7.4 to fix #258 ?

cc @ibennetch

@J0WI J0WI changed the title Update to PHP 7.3 Update to PHP 7.4 Dec 13, 2019
@J0WI
Copy link
Contributor Author

J0WI commented Dec 13, 2019

Done

@williamdes williamdes requested review from ibennetch and MauricioFauth and removed request for ibennetch December 13, 2019 08:22
@ibennetch
Copy link
Member

ibennetch commented Dec 14, 2019

Looks good to me. Thank you for this.

Soon I can release docker version 4.9.2-2 to include this patch and and #259.

@fruitl00p
Copy link

Any timeline for getting the official images updated to 7.4?

@ibennetch
Copy link
Member

ibennetch commented Dec 19, 2019 via email

@fruitl00p
Copy link

fruitl00p commented Dec 19, 2019 via email

@ibennetch ibennetch merged commit b696c1f into phpmyadmin:master Dec 20, 2019
@ibennetch
Copy link
Member

I've merged this change and pushed a new Docker tag so 7.4 should be building now for all the current Docker tags. There's even a 4.9.2-2 tag for this.

@J0WI thank you for doing this work.

@williamdes williamdes self-assigned this Dec 20, 2019
@J0WI J0WI deleted the php73 branch December 20, 2019 17:46
@williamdes williamdes mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants