New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to PHP 7.4 #257
Update to PHP 7.4 #257
Conversation
@J0WI can you do the upgrade to 7.4 to fix #258 ? cc @ibennetch |
Done |
Looks good to me. Thank you for this. Soon I can release docker version 4.9.2-2 to include this patch and and #259. |
Any timeline for getting the official images updated to 7.4? |
Robin, probably this weekend, at least I hope so. I may get to updating
'master' tonight.
I'm a little unsure if I should release Docker tags like 4.9.2-2 for this
or if users will pull by digest (see
#259 (comment) and
feel free to comment if you have any input).
|
i personally have never seen any pulling by digest in the wild by users...
anyway, looking forward to a 7.4 release... But could also wait for a
normal version tag to achieve that new crispy 7.4 feeling 😀
Op do 19 dec. 2019 20:27 schreef Isaac Bennetch <notifications@github.com>:
… Robin, probably this weekend, at least I hope so. I may get to updating
'master' tonight.
I'm a little unsure if I should release Docker tags like 4.9.2-2 for this
or if users will pull by digest (see
#259 (comment) and
feel free to comment if you have any input).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#257?email_source=notifications&email_token=AALMO7MEO5KDTNPXHOI24PDQZPDJBA5CNFSM4JTC3UHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHKVITI#issuecomment-567628877>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALMO7OPDA4WTQKXFCSCWC3QZPDJBANCNFSM4JTC3UHA>
.
|
I've merged this change and pushed a new Docker tag so 7.4 should be building now for all the current Docker tags. There's even a @J0WI thank you for doing this work. |
No description provided.