Graphs #12

Merged
merged 19 commits into from Aug 21, 2013

Conversation

Projects
None yet
2 participants
Contributor

m0hamed commented Aug 18, 2013

  • added graphs to the reports view
  • syntax highlighting
  • fallback if error occurs in error_report.js script

m0hamed added some commits Aug 14, 2013

ruleant was assigned Aug 20, 2013

@ruleant ruleant and 1 other commented on an outdated diff Aug 20, 2013

app/View/Helper/ReportsHelper.php
@@ -59,6 +60,22 @@ public function getStacktracesForIncidents($incidents) {
return $html;
}
+ public function getChartArray($arrayName, $columns, $relatedEntries) {
+ $html = "var $arrayName = [], chart = {};";
+ foreach ($columns as $column) {
+ $html .= "chart = {};";
+ $html .= "chart.name = '$column';";
@ruleant

ruleant Aug 20, 2013

Contributor

shouldn't $column be escaped with htmlspecialchars() or a similar function?

@m0hamed

m0hamed Aug 20, 2013

Contributor

$columns is an array that I have defined in the controller to store the list of summarizable columns in one place so its not exactly user entered but using htmlspecialchars() wouldnt hurt

@ruleant

ruleant Aug 20, 2013

Contributor

please escape it, better safe than sorry. ;) You never know what might end up in the array in the future.

@m0hamed

m0hamed Aug 20, 2013

Contributor

I escaped it just in case

ruleant was assigned Aug 21, 2013

ruleant merged commit 3427493 into phpmyadmin:master Aug 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment