Skip to content

Commit 10014d4

Browse files
madhuracjMarc Delisle
authored and
Marc Delisle
committed
bug #4488 [security] XSS injection due to unescaped table name (triggers)
Signed-off-by: Marc Delisle <marc@infomarc.info>
1 parent 5747537 commit 10014d4

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Diff for: ChangeLog

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ phpMyAdmin - ChangeLog
1212
- bug #4440 Javascript error when renaming table
1313
- bug #4483 'New window' link (selflink) disappears, causing Javascript error
1414
- bug #4486 [security] XSS injection due to unescaped table comment
15+
- bug #4488 [security] XSS injection due to unescaped table name (triggers)
1516

1617
4.2.5.0 (2014-06-26)
1718
- bug #4467 shell_exec() has been disabled for security reasons

Diff for: libraries/rte/rte_list.lib.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,9 @@ function PMA_TRI_getRowForList($trigger, $rowclass = '')
259259
$retval .= " </td>\n";
260260
if (empty($table)) {
261261
$retval .= " <td>\n";
262-
$retval .= " <a href='db_triggers.php?{$url_query}"
263-
. "&amp;table={$trigger['table']}'>"
264-
. $trigger['table'] . "</a>\n";
262+
$retval .= "<a href='db_triggers.php?{$url_query}"
263+
. "&amp;table=" . urlencode($trigger['table']) . "'>"
264+
. urlencode($trigger['table']) . "</a>";
265265
$retval .= " </td>\n";
266266
}
267267
$retval .= " <td>\n";

0 commit comments

Comments
 (0)