From 50eb1e533cf253c49932bc9ca9a40e63feb313fa Mon Sep 17 00:00:00 2001 From: William Desportes Date: Sun, 28 Apr 2024 16:55:49 +0200 Subject: [PATCH 1/3] Remove stale.yml on QA Signed-off-by: William Desportes --- .github/stale.yml | 23 ----------------------- 1 file changed, 23 deletions(-) delete mode 100644 .github/stale.yml diff --git a/.github/stale.yml b/.github/stale.yml deleted file mode 100644 index 8ed0f30aac2f..000000000000 --- a/.github/stale.yml +++ /dev/null @@ -1,23 +0,0 @@ -# Configuration for probot-stale - https://github.com/probot/stale - -# Number of days of inactivity before an Issue or Pull Request becomes stale -daysUntilStale: 60 -# Number of days of inactivity before a stale Issue or Pull Request is closed -daysUntilClose: 7 -# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable -exemptLabels: - - pinned - - security -# Label to use when marking as stale -staleLabel: wontfix -# Comment to post when marking as stale. Set to `false` to disable -markComment: > - This issue has been automatically marked as stale because it has not had - recent activity. It will be closed if no further activity occurs. Thank you - for your contributions. -# Comment to post when removing the stale label. Set to `false` to disable -unmarkComment: false -# Comment to post when closing a stale Issue or Pull Request. Set to `false` to disable -closeComment: false -# Limit to only `issues` or `pulls` -only: pulls From 892dda0f04ceb6c830900b1d426b87d2029a5bce Mon Sep 17 00:00:00 2001 From: William Desportes Date: Sun, 28 Apr 2024 17:18:43 +0200 Subject: [PATCH 2/3] Fix #19041 - footer.twig gets printed to Binary File Download Signed-off-by: William Desportes --- .../classes/Controllers/Transformation/WrapperController.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libraries/classes/Controllers/Transformation/WrapperController.php b/libraries/classes/Controllers/Transformation/WrapperController.php index 7c850e6ea55f..4b3f58633b68 100644 --- a/libraries/classes/Controllers/Transformation/WrapperController.php +++ b/libraries/classes/Controllers/Transformation/WrapperController.php @@ -143,6 +143,8 @@ public function __invoke(): void } } + // Disabling standard response, we are sending binary here + $this->response->disable(); $this->response->getHeader()->sendHttpHeaders(); // [MIME] From 69d9b8b85ce12c58c440085d6791dc7914d3f69a Mon Sep 17 00:00:00 2001 From: William Desportes Date: Sun, 28 Apr 2024 17:24:26 +0200 Subject: [PATCH 3/3] Add a ChangeLog entry for #19041 Signed-off-by: William Desportes --- ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog b/ChangeLog index 944d11ff429f..b01a8b776221 100644 --- a/ChangeLog +++ b/ChangeLog @@ -82,6 +82,7 @@ phpMyAdmin - ChangeLog - issue #19125 Fixed CodeMirror tooltip is below modals - issue #18674 Fix formatted sql in browse table result has a linebreak after each token - issue #18210 Fixed add replica replication user on MariaDB doesn't work (SQL syntax) +- issue #19041 Fix footer.twig gets printed to Binary File Download 5.2.1 (2023-02-07) - issue #17522 Fix case where the routes cache file is invalid