diff --git a/ChangeLog b/ChangeLog index bf3f75b79b19..a5d72cb458d1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -23,6 +23,7 @@ phpMyAdmin - ChangeLog - issue Removed MySQL connection retry without password - issue #12218 Allow to specify further parameters for control connection - issue #12162 Show charset for each table on Database structure page +- issue #12463 Incorrect link in the href of icon at Hide/Show unhide links 4.6.5 (not yet released) - issue Remove potentionally license problematic sRGB profile diff --git a/js/navigation.js b/js/navigation.js index 05455c211115..81a07175e49d 100644 --- a/js/navigation.js +++ b/js/navigation.js @@ -522,6 +522,9 @@ $(function () { event.preventDefault(); $.ajax({ type: 'POST', + data: { + token: PMA_commonParams.get('token') + }, url: $(this).attr('href') + '&ajax_request=true', success: function (data) { if (typeof data !== 'undefined' && data.success === true) { @@ -570,6 +573,9 @@ $(function () { var $msg = PMA_ajaxShowMessage(); $.ajax({ type: 'POST', + data: { + token: PMA_commonParams.get('token') + }, url: $(this).attr('href') + '&ajax_request=true', success: function (data) { PMA_ajaxRemoveMessage($msg); diff --git a/libraries/URL.php b/libraries/URL.php index 5bc6dbd1baeb..03ff8463dca7 100644 --- a/libraries/URL.php +++ b/libraries/URL.php @@ -220,10 +220,6 @@ public static function getCommonRaw($params = array(), $divider = '?') $params['collation_connection'] = $GLOBALS['collation_connection']; } - if (empty($params)) { - return ''; - } - return $divider . http_build_query($params, null, $separator); } diff --git a/libraries/navigation/Navigation.php b/libraries/navigation/Navigation.php index 5f8ccb6a1c62..4b4e19fddc24 100644 --- a/libraries/navigation/Navigation.php +++ b/libraries/navigation/Navigation.php @@ -207,14 +207,17 @@ public function getItemUnhideDialog($dbName, $itemType = null, $tableName = null $html .= ''; $odd = true; foreach ($hidden[$t] as $hiddenItem) { + $params = array( + 'unhideNavItem' => true, + 'itemType' => $t, + 'itemName' => $hiddenItem, + 'dbName' => $dbName + ); + $html .= ''; $html .= ''; $html .= ''; diff --git a/libraries/navigation/nodes/NodeDatabase.php b/libraries/navigation/nodes/NodeDatabase.php index 18b48a53f3ac..81d537c77c98 100644 --- a/libraries/navigation/nodes/NodeDatabase.php +++ b/libraries/navigation/nodes/NodeDatabase.php @@ -687,11 +687,13 @@ public function getHtmlForControlButtons() $cfgRelation = PMA_getRelationsParam(); if ($cfgRelation['navwork']) { if ($this->hiddenCount > 0) { + $params = array( + 'showUnhideDialog' => true, + 'dbName' => $this->real_name, + ); $ret = '' . '' . Util::getImage( 'show.png', diff --git a/libraries/navigation/nodes/NodeDatabaseChild.php b/libraries/navigation/nodes/NodeDatabaseChild.php index bea913c9f795..4568bc9f94e7 100644 --- a/libraries/navigation/nodes/NodeDatabaseChild.php +++ b/libraries/navigation/nodes/NodeDatabaseChild.php @@ -38,13 +38,17 @@ public function getHtmlForControlButtons() if ($cfgRelation['navwork']) { $db = $this->realParent()->real_name; $item = $this->real_name; + + $params = array( + 'hideNavItem' => true, + 'itemType' => $this->getItemType(), + 'itemName' => $item, + 'dbName' => $db + ); + $ret = '' . '' . PMA\libraries\Util::getImage('hide.png', __('Hide')) . '';
' . htmlspecialchars($hiddenItem) . '' . Util::getIcon('show.png', __('Show')) . '