Skip to content

Commit

Permalink
Fix HHVM tests.
Browse files Browse the repository at this point in the history
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
  • Loading branch information
Dan Ungureanu committed Jul 10, 2015
1 parent 2dfc29d commit 7c60eba
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
Expand Up @@ -95,6 +95,12 @@ public function testGetSetForce()
*/
public function testGetPropertyType()
{
if ((defined('HHVM_VERSION')
&& (version_compare(constant('HHVM_VERSION'), '3.8', 'lt')))
) {
$this->markTestSkipped('Due to a bug in early versions of HHVM, this test cannot be completed.');
}

$this->assertEquals(
'options',
$this->stub->getPropertyType()
Expand Down
Expand Up @@ -44,6 +44,12 @@ public function tearDown()
*/
public function testGetPropertyType()
{
if ((defined('HHVM_VERSION')
&& (version_compare(constant('HHVM_VERSION'), '3.8', 'lt')))
) {
$this->markTestSkipped('Due to a bug in early versions of HHVM, this test cannot be completed.');
}

$this->assertEquals(
"plugin",
$this->stub->getPropertyType()
Expand Down

2 comments on commit 7c60eba

@nijel
Copy link
Contributor

@nijel nijel commented on 7c60eba Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if the commit message or comment in the code would mention what the bug is or what problem it is workarounding. When adding tests for later hhvm versions (see #13041), I've noticed that these tests take quite long there, so it might be related...

@nijel
Copy link
Contributor

@nijel nijel commented on 7c60eba Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and strangely enough, these tests work just fine on hhvm 3.3, see https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/206928468

Please sign in to comment.