Rewrite Setup settings forms as classes

Signed-off-by: Michal Čihař <michal@cihar.com>
phpmyadmin · Sep 6, 2017 · 8490d3a · 8490d3a
1 parent 1fb2887
commit 8490d3a
Show file tree

Hide file tree

Showing 15 changed files with 303 additions and 419 deletions.
diff --git a/libraries/classes/Config/Forms/Setup/ConfigForm.php b/libraries/classes/Config/Forms/Setup/ConfigForm.php
@@ -0,0 +1,23 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * User preferences form
+ *
+ * @package PhpMyAdmin
+ */
+namespace PhpMyAdmin\Config\Forms\Setup;
+
+use PhpMyAdmin\Config\Forms\BaseForm;
+
+class ConfigForm extends BaseForm
+{
+    public static function getForms()
+    {
+        return array(
+            'Config' => array(
+                'DefaultLang',
+                'ServerDefault'
+            ),
+        );
+    }
+}
diff --git a/libraries/classes/Config/Forms/Setup/ExportForm.php b/libraries/classes/Config/Forms/Setup/ExportForm.php
@@ -0,0 +1,12 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * User preferences form
+ *
+ * @package PhpMyAdmin
+ */
+namespace PhpMyAdmin\Config\Forms\Setup;
+
+class ExportForm extends \PhpMyAdmin\Config\Forms\User\ExportForm
+{
+}
diff --git a/libraries/classes/Config/Forms/Setup/FeaturesForm.php b/libraries/classes/Config/Forms/Setup/FeaturesForm.php
@@ -0,0 +1,60 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * User preferences form
+ *
+ * @package PhpMyAdmin
+ */
+namespace PhpMyAdmin\Config\Forms\Setup;
+
+class FeaturesForm extends \PhpMyAdmin\Config\Forms\User\FeaturesForm
+{
+    public static function getForms()
+    {
+        $result = parent::getForms();
+        /* Remove only_db/hide_db, we have proper Server form in setup */
+        $result['Databases'] = array_diff(
+            $result['Databases'],
+            ['Servers/1/only_db', 'Servers/1/hide_db']
+        );
+        /* Following are not available to user */
+        $result['Import_export'] = array(
+            'UploadDir',
+            'SaveDir',
+            'RecodingEngine' => ':group',
+                'IconvExtraParams',
+                ':group:end',
+            'ZipDump',
+            'GZipDump',
+            'BZipDump',
+            'CompressOnFly'
+        );
+        $result['Security'] = array(
+            'blowfish_secret',
+            'CheckConfigurationPermissions',
+            'TrustedProxies',
+            'AllowUserDropDatabase',
+            'AllowArbitraryServer',
+            'ArbitraryServerRegexp',
+            'LoginCookieRecall',
+            'LoginCookieStore',
+            'LoginCookieDeleteAll',
+            'CaptchaLoginPublicKey',
+            'CaptchaLoginPrivateKey'
+        );
+        $result['Developer'][] = 'UserprefsDeveloperTab';
+        $result['Other_core_settings'] = array(
+            'OBGzip',
+            'PersistentConnections',
+            'ExecTimeLimit',
+            'MemoryLimit',
+            'UseDbSearch',
+            'ProxyUrl',
+            'ProxyUser',
+            'ProxyPass',
+            'AllowThirdPartyFraming',
+            'ZeroConf',
+        );
+        return $result;
+    }
+}
diff --git a/libraries/classes/Config/Forms/Setup/ImportForm.php b/libraries/classes/Config/Forms/Setup/ImportForm.php
@@ -0,0 +1,12 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * User preferences form
+ *
+ * @package PhpMyAdmin
+ */
+namespace PhpMyAdmin\Config\Forms\Setup;
+
+class ImportForm extends \PhpMyAdmin\Config\Forms\User\ImportForm
+{
+}
diff --git a/libraries/classes/Config/Forms/Setup/MainForm.php b/libraries/classes/Config/Forms/Setup/MainForm.php
@@ -0,0 +1,20 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * User preferences form
+ *
+ * @package PhpMyAdmin
+ */
+namespace PhpMyAdmin\Config\Forms\Setup;
+
+class MainForm extends \PhpMyAdmin\Config\Forms\User\MainForm
+{
+    public static function getForms()
+    {
+        $result = parent::getForms();
+        /* Following are not available to user */
+        $result['Startup'][] = 'ShowPhpInfo';
+        $result['Startup'][] = 'ShowChgPassword';
+        return $result;
+    }
+}
diff --git a/libraries/classes/Config/Forms/Setup/NaviForm.php b/libraries/classes/Config/Forms/Setup/NaviForm.php
@@ -0,0 +1,12 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * User preferences form
+ *
+ * @package PhpMyAdmin
+ */
+namespace PhpMyAdmin\Config\Forms\Setup;
+
+class NaviForm extends \PhpMyAdmin\Config\Forms\User\NaviForm
+{
+}
diff --git a/libraries/classes/Config/Forms/Setup/ServersForm.php b/libraries/classes/Config/Forms/Setup/ServersForm.php
@@ -0,0 +1,81 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * User preferences form
+ *
+ * @package PhpMyAdmin
+ */
+namespace PhpMyAdmin\Config\Forms\Setup;
+
+use PhpMyAdmin\Config\Forms\BaseForm;
+
+class ServersForm extends BaseForm
+{
+    public static function getForms()
+    {
+        return array(
+            'Server' => array('Servers' => array(1 => array(
+                'verbose',
+                'host',
+                'port',
+                'socket',
+                'ssl',
+                'compress'))),
+            'Server_auth' => array('Servers' => array(1 => array(
+                'auth_type',
+                ':group:' . __('Config authentication'),
+                    'user',
+                    'password',
+                    ':group:end',
+                ':group:' . __('HTTP authentication'),
+                    'auth_http_realm',
+                    ':group:end',
+                ':group:' . __('Signon authentication'),
+                    'SignonSession',
+                    'SignonURL',
+                    'LogoutURL'))),
+            'Server_config' => array('Servers' => array(1 => array(
+                'only_db',
+                'hide_db',
+                'AllowRoot',
+                'AllowNoPassword',
+                'DisableIS',
+                'AllowDeny/order',
+                'AllowDeny/rules',
+                'SessionTimeZone'))),
+            'Server_pmadb' => array('Servers' => array(1 => array(
+                'pmadb' => 'phpmyadmin',
+                'controlhost',
+                'controlport',
+                'controluser',
+                'controlpass',
+                'bookmarktable' => 'pma__bookmark',
+                'relation' => 'pma__relation',
+                'userconfig' => 'pma__userconfig',
+                'users' => 'pma__users',
+                'usergroups' => 'pma__usergroups',
+                'navigationhiding' => 'pma__navigationhiding',
+                'table_info' => 'pma__table_info',
+                'column_info' => 'pma__column_info',
+                'history' => 'pma__history',
+                'recent' => 'pma__recent',
+                'favorite' => 'pma__favorite',
+                'table_uiprefs' => 'pma__table_uiprefs',
+                'tracking' => 'pma__tracking',
+                'table_coords' => 'pma__table_coords',
+                'pdf_pages' => 'pma__pdf_pages',
+                'savedsearches' => 'pma__savedsearches',
+                'central_columns' => 'pma__central_columns',
+                'designer_settings' => 'pma__designer_settings',
+                'export_templates' => 'pma__export_templates',
+                'MaxTableUiprefs' => 100))),
+            'Server_tracking' => array('Servers' => array(1 => array(
+                'tracking_version_auto_create',
+                'tracking_default_statements',
+                'tracking_add_drop_view',
+                'tracking_add_drop_table',
+                'tracking_add_drop_database',
+            ))),
+        );
+    }
+}
diff --git a/libraries/classes/Config/Forms/Setup/SetupFormList.php b/libraries/classes/Config/Forms/Setup/SetupFormList.php
@@ -0,0 +1,25 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * Setup preferences form
+ *
+ * @package PhpMyAdmin
+ */
+namespace PhpMyAdmin\Config\Forms\Setup;
+
+use PhpMyAdmin\Config\Forms\BaseFormList;
+
+class SetupFormList extends BaseFormList
+{
+    protected static $all = array(
+        'Config',
+        'Export',
+        'Features',
+        'Import',
+        'Main',
+        'Navi',
+        'Servers',
+        'Sql',
+    );
+    protected static $ns = 'PhpMyAdmin\\Config\\Forms\\Setup\\';
+}
diff --git a/libraries/classes/Config/Forms/Setup/SqlForm.php b/libraries/classes/Config/Forms/Setup/SqlForm.php
@@ -0,0 +1,19 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * User preferences form
+ *
+ * @package PhpMyAdmin
+ */
+namespace PhpMyAdmin\Config\Forms\Setup;
+
+class SqlForm extends \PhpMyAdmin\Config\Forms\User\SqlForm
+{
+    public static function getForms()
+    {
+        $result = parent::getForms();
+        /* Following are not available to user */
+        $result['Sql_queries'][] = 'QueryHistoryDB';
+        return $result;
+    }
+}