From 4848ccb481ab58605e733852551e92e71f6e192c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Sat, 19 Feb 2022 17:52:05 -0300
Subject: [PATCH] Disable editing to system schemas
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Fixes #16816

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 libraries/classes/Sql.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libraries/classes/Sql.php b/libraries/classes/Sql.php
index edb168816f31..ca4978727e5d 100644
--- a/libraries/classes/Sql.php
+++ b/libraries/classes/Sql.php
@@ -1543,7 +1543,8 @@ private function getQueryResponseForResultsReturned(
         $editable = ($has_unique
             || $GLOBALS['cfg']['RowActionLinksWithoutUnique']
             || $updatableView)
-            && $just_one_table;
+            && $just_one_table
+            && ! Utilities::isSystemSchema($db);
 
         $_SESSION['tmpval']['possible_as_geometry'] = $editable;
 
@@ -1557,7 +1558,7 @@ private function getQueryResponseForResultsReturned(
             'pview_lnk' => '1',
         ];
 
-        if (Utilities::isSystemSchema($db) || ! $editable) {
+        if (! $editable) {
             $displayParts = [
                 'edit_lnk' => $displayResultsObject::NO_EDIT_OR_DELETE,
                 'del_lnk' => $displayResultsObject::NO_EDIT_OR_DELETE,