diff --git a/ChangeLog b/ChangeLog index 4372f0e23031..28f5fe7a3acf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,9 @@ phpMyAdmin - ChangeLog ====================== +4.3.13.1 (Not yet released) +- bug #4899 [security] CSRF vulnerability in setup + 4.3.13.0 (2015-03-29) - bug #4803 "Show hidden items" is sometimes hidden - bug #4807 Breaks when sorting by multiple columns while using UNION diff --git a/libraries/url_generating.lib.php b/libraries/url_generating.lib.php index 0641f5aa334f..fec864eba91e 100644 --- a/libraries/url_generating.lib.php +++ b/libraries/url_generating.lib.php @@ -179,6 +179,7 @@ function PMA_URL_getCommon($params = array(), $encode = 'html', $divider = '?') if (isset($GLOBALS['server']) && $GLOBALS['server'] != $GLOBALS['cfg']['ServerDefault'] && ! isset($params['server']) + && ! defined('PMA_SETUP') ) { $params['server'] = $GLOBALS['server']; } diff --git a/setup/frames/form.inc.php b/setup/frames/form.inc.php index 2fb2cda0f447..4e25bfe1d2c3 100644 --- a/setup/frames/form.inc.php +++ b/setup/frames/form.inc.php @@ -19,8 +19,8 @@ require './libraries/config/setup.forms.php'; -$formset_id = filter_input(INPUT_GET, 'formset'); -$mode = filter_input(INPUT_GET, 'mode'); +$formset_id = isset($_GET['formset']) ? $_GET['formset'] : null; +$mode = isset($_GET['mode']) ? $_GET['mode'] : null; if (! isset($forms[$formset_id])) { PMA_fatalError(__('Incorrect formset, check $formsets array in setup/frames/form.inc.php!')); } diff --git a/setup/frames/index.inc.php b/setup/frames/index.inc.php index c291c3c3275d..2c341ec2c99a 100644 --- a/setup/frames/index.inc.php +++ b/setup/frames/index.inc.php @@ -174,12 +174,12 @@ echo '' . htmlspecialchars($cf->getServerDSN($id)) . ''; echo ''; echo ''; - echo '' + echo '' . __('Edit') . ''; echo ' | '; - echo '' + echo '' . __('Delete') . ''; echo ''; echo ''; @@ -308,7 +308,6 @@ echo '' . __('phpMyAdmin homepage') . ''; echo '' . __('Donate') . ''; -echo '' +echo '' . __('Check for latest version') . ''; echo ''; diff --git a/setup/frames/menu.inc.php b/setup/frames/menu.inc.php index d82dce07f261..a78c84d689fe 100644 --- a/setup/frames/menu.inc.php +++ b/setup/frames/menu.inc.php @@ -10,11 +10,11 @@ exit; } -$formset_id = filter_input(INPUT_GET, 'formset'); +$formset_id = isset($_GET['formset']) ? $_GET['formset'] : null; $separator = PMA_URL_getArgSeparator('html'); echo '