From 9f3b4f04e98f686bfd58c31a2b6405bd1cf57708 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Mon, 27 Sep 2021 19:18:48 -0300 Subject: [PATCH] Wrap variable variables in curly braces MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See: https://www.php.net/manual/en/language.variables.variable.php Signed-off-by: Maurício Meneghini Fauth --- libraries/classes/DatabaseInterface.php | 8 ++++---- libraries/classes/Git.php | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libraries/classes/DatabaseInterface.php b/libraries/classes/DatabaseInterface.php index 670b4cd4b8fb..a679186067c6 100644 --- a/libraries/classes/DatabaseInterface.php +++ b/libraries/classes/DatabaseInterface.php @@ -553,16 +553,16 @@ static function ($a, $b) { } } - if (! empty($$sort_by)) { + if (! empty(${$sort_by})) { if ($sort_order === 'DESC') { - array_multisort($$sort_by, SORT_DESC, $each_tables); + array_multisort(${$sort_by}, SORT_DESC, $each_tables); } else { - array_multisort($$sort_by, SORT_ASC, $each_tables); + array_multisort(${$sort_by}, SORT_ASC, $each_tables); } } // cleanup the temporary sort array - unset($$sort_by); + unset(${$sort_by}); } if ($limit_count) { diff --git a/libraries/classes/Git.php b/libraries/classes/Git.php index 6e9f86d209ef..3641cf1a0d8a 100644 --- a/libraries/classes/Git.php +++ b/libraries/classes/Git.php @@ -394,7 +394,7 @@ private function extractDataFormTextBody(array $commit): array $user2['date'] .= $user[4]; } - $$linetype = $user2; + ${$linetype} = $user2; } while ($dataline != ''); $message = trim(implode(' ', $commit));